C++ to C# code converstion

Question

0.00/5 (No votes)

See more:

Hello,

can any one help me to convert below C++ code to c#
stuck with below line:

sOutString.Format(_T("%s %s"), sTimeStamp, sBoardIdentNumber);

Original:

{
  int i, len;
  unsigned char acBuffer[64];
  CString sOutString;
  static char acOut[180];
  sOutString.Format( _T("%s %s"), sTimeStamp, sBoardIdentNumber);
  len = sOutString.GetLength();
 	for( i = 0; i<len; i++)
		acBuffer[i] = sOutString.GetAt(i);
  acBuffer[len] = 0;

  long lCRC = CalculateCRC32( acBuffer, len );
  _snprintf_s(acOut, sizeof(acOut), "%8x", lCRC );

  len = strlen(acOut);
	for( i = 0; i<len; i++)
		acOut[i] = toupper(acOut[i]);

  return acOut;
}

What I have tried:

equivalent C# i tried:

{
      int len;
      byte[] acBuffer = new byte[64];
      string sOutString = null;
      char[] acOut = new char[180];
      //sOutString.Format(_T("%s %s"), sTimeStamp, sBoardIdentNumber);

      len = sOutString.Length;
      for(int i = 0;i < len;i++)
      {
        acBuffer[i] = (byte)sOutString[i];
      }
      acBuffer[len] = 0;

      long lCRC = CalculateCRC32(acBuffer, len);

      len = acOut.Length;
      for (int i = 0; i < len; i++)
      {
        acOut[i] = char.ToUpper(acOut[i]);
      }       

      return acOut;
    }

Posted 18-Jan-17 20:37pm

indyarock

Updated 19-Jan-17 2:09am

KarstenK

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2017-01-18T20:47:00

Solution 1

Try:

C#

sOutString = String.Format("{0} {1}", sTimeStamp, sBoardIdentNumber);

Posted 18-Jan-17 20:47pm

OriginalGriff

Comments

indyarock 19-Jan-17 4:21am

yes, it works well.
and i forgot one more line to include.
any idea of c# equivalent for below line?

_snprintf_s(acOut, sizeof(acOut), "%8x", lCRC );

OriginalGriff 19-Jan-17 4:39am

There isn't one: C# strings do not work on a null terminator.
If what you are trying to do is convert a long to an 8 character hex string all in uppercase, then just use ToString:

long v = 12345678;
string s = v.ToString("X8");

will give you "00BC614E" and eliminate you loop as well.
Do yourself a favour: line by line translations of any language to another do not generally produce good code, no matter how good it was in the original. This is particularly relevant with "old fashioned" C++ to C# because the latter uses the .NET framework which automates a lot of what has to be manual without it.
If you are lifting code from the internet and trying to translate it, be aware that it may not be the best way to do things!

indyarock 31-Jan-17 1:36am

Thank you :)
it helped