Why my code is giving output as segmentation fault?

Question

1.00/5 (2 votes)

See more:

this is to to take out sum of three no using calling function but here i have used pointer so what hell the difference has been created and why segmentation fault is the output

What I have tried:

<pre>#include<stdio.h>
int *calsum(int x,int y,int z);
int main()
{
    while(1)
    {
 int a,b,c,sum;
 printf("Enter any3 numbers");
 scanf("%d%d%d",&a,&b,&c);
 sum=*calsum(a,b,c);
 printf("sum=%d\n",sum);
    }
}
 int *calsum (int x,int y,int z)
 {
 return x+y+z;
 }
<

Posted 21-Feb-17 7:22am

Member 13015247

Updated 21-Feb-17 9:05am

v2

Add a Solution

Comments

[no name] 21-Feb-17 13:44pm

Mostly because it's not C# code?
http://www.cprogramming.com/debugging/segfaults.html

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-02-21T08:08:00

That's not C# - that's "straight" C, or very-much-beginner-C++.
And if you look closely at what your calcsum returns, the problem is pretty obvious.
What is x + y + z where x, y, and z are all integers?
Simple: it's an integer, just as 666, 42, and 7 are all integers. What that isn;t is a pointer-to-an-integer which is what the function says it is returning, and your code assumes it actually is and dereferences the pointer. Since "666" isn't a pointer into valid memory, the system rightly assumes your program is broken, and issues a segmentation fault.
Take out the "*" from the function definition, and from the line where you call it. It'll work then.

Patrice T · Answer 2 · 2017-02-21T09:05:00

First, this return an integer, not a pointer to an integer

C++

return x+y+z;

Second, the value is on stack, so even if the pointer id as expected, the value will be trashed the call to printf.
You a lot of lecture ahaed to learn seriously C and C++.

Here is links to references books on C and C++ by the authors of the languages. Note than C is the ancestor of C++, so knowing C is always useful with C++.
The C Programming Language - Wikipedia, the free encyclopedia[^]
https://hassanolity.files.wordpress.com/2013/11/the_c_programming_language_2.pdf[^]
http://www.ime.usp.br/~pf/Kernighan-Ritchie/C-Programming-Ebook.pdf[^]

C++ Programing Language[^]

Learning to use the debugger will help too.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute, it is an incredible learning tool.

Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

Why my code is giving output as segmentation fault?

2 solutions

Solution 2

Solution 3

Add your solution here

Preview 0