Stored procedure returning null value to parameter during creating a new user

Question

1.00/5 (2 votes)

See more:

I have A button To add User, if i click Button a pop Up comes to add user,

But While Saving I am getting a exception user id not supplied to procedure..

In Table login userid is int not null.

I kept a debugger and tried @userid is null..And procedre is expecting a parameter @userid, where i am going wrong ,

Any stored procedre problem, any suggestions to change my stored procedre

ideas??

suggestions??

What I have tried:

SQL

ALTER PROCEDURE logins @UserId VARCHAR(50)
	,@UserName VARCHAR(100)
	,@FirstName VARCHAR(100)
	,@LastName VARCHAR(100)
	,@Email VARCHAR(200)
	,@Password VARCHAR(100)
	,@AllNames VARCHAR(max)
AS
BEGIN
	IF @UserId IS NULL
		INSERT INTO logins (
			UserName
			,FirstName
			,LastName
			,Email
			,ROLE
			,DateCreated
			,DateModified
			,Password
			,Allnames
			)
		VALUES (
			@UserName
			,@FirstName
			,@LastName
			,@Email
			,'Admin'
			,GetDate()
			,GetDate()
			,@Password
			,@allnames
			)
	ELSE
		UPDATE logins
		SET UserName = @UserName
			,FirstName = @FirstName
			,LastName = @LastName
			,AllNames = @Allnames
		WHERE UserId = @UserId
END

Posted 17-Mar-17 5:12am

Mahesh2223

Updated 17-Mar-17 7:03am

v3

Add a Solution

Comments

[no name] 17-Mar-17 11:15am

userid is int
UserId varchar(50)

Do you see something wrong with these two lines?
And the error message is clear. You are calling your stored procedure and not supplying the user id parameter that it expects.

Mahesh2223 17-Mar-17 11:19am

That automatically generates id's based on users

Mahesh2223 18-Mar-17 1:17am

U are correct I changed to int , its working , thnx man

ZurdoDev 17-Mar-17 11:20am

"a exception user id not supplied to procedure.." - That means your c# code did not send the parameter. Click Improve question and post the c# code where you call this stored procedure.

farid.masood 17-Mar-17 13:11pm

What is the datatype of your UserID column? I mean you are declaring it as VARCHAR but what is the type in the actual column?

Mahesh2223 18-Mar-17 0:50am

int not null

farid.masood 22-Mar-17 5:59am

Glad you fixed it :)

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ramesh Kumar Barik · Accepted Answer · 2017-03-17T06:14:00

Set @UserId VARCHAR(50)=null.
If UserID in an integer field then take parameter as Int.

EX:
ALTER PROCEDURE logins @UserId int = null
,@UserName VARCHAR(100)
,@FirstName VARCHAR(100)
,@LastName VARCHAR(100)
,@Email VARCHAR(200)
,@Password VARCHAR(100)
,@AllNames VARCHAR(max)
AS
BEGIN
IF @UserId IS NULL
INSERT INTO logins (
UserName
,FirstName
,LastName
,Email
,ROLE
,DateCreated
,DateModified
,Password
,Allnames
)
VALUES (
@UserName
,@FirstName
,@LastName
,@Email
,'Admin'
,GetDate()
,GetDate()
,@Password
,@allnames
)
ELSE
UPDATE logins
SET UserName = @UserName
,FirstName = @FirstName
,LastName = @LastName
,AssignedGroups = @Allnames
WHERE UserId = @UserId
END