Problem trying to convert type 'double' to 'int'

Question

1.00/5 (3 votes)

See more:

private Product CreateProduct()
    {
        Product product = new Product();

        product.Name = txtName.Text;
        product.Price = Convert.ToDouble(txtPrice.Text);
        product.TypeID = Convert.ToInt32(ddlType.SelectedValue);
        product.Description = txtDescription.Text;
        product.Image = ddlImage.SelectedValue;

        return product;
    }

What I have tried:

I've tried Convert.ToInt32(txtPrice.Text);, but that doesnt work either

Posted 17-Mar-17 6:20am

Member 13066229

Updated 17-Mar-17 9:09am

Add a Solution

Comments

[no name] 17-Mar-17 12:30pm

That's because you should be using Double.TryParse instead.

2 solutions

Solution 2

Try:

C#

double price;
if (!double.TryParse(txtPrice.Text, out price))
   {
   // Report input problem to user.
   ...
   return;
   }
product.Price = price;

If Price is an integer - and it probably shouldn't be - then try:

C#

double price;
if (!double.TryParse(txtPrice.Text, out price))
   {
   // Report input problem to user.
   ...
   return;
   }
product.Price = (int) price;

Never use Convert.To... to handle user input: it always throws an exception on bad values, and users make mistakes all the time. If you had filled out a form with a whole bunch of data, and the app then crashed because you types "," instead of "." you'd be pretty annoyed - so allow users to make mistakes and get them to correct them!

Posted 17-Mar-17 6:44am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bryian Tan · Accepted Answer · 2017-03-17T09:09:00

Hmmmmm. I been thinking, since the Textbox name is txtPrice, I was wondering if the box is holding string with currency format like (£12.30). If that the case, try follow the below example

C#

System.Globalization.CultureInfo provider = new System.Globalization.CultureInfo("en-GB");
    string txtPrice = "£12.30";
    double price;
    double.TryParse(txtPrice, System.Globalization.NumberStyles.AllowThousands |
      System.Globalization.NumberStyles.AllowDecimalPoint |
      System.Globalization.NumberStyles.AllowCurrencySymbol, provider, out price);
    product.Price = price;

Output: 12.3
if price is an integer

C#

product.Price = (int)price;

Output: 12