Filling datagridview combobox

Question

1.00/5 (2 votes)

See more:

I want to fill combobox in datagrid with name of items not the id

i have this code :

its working fine but it dosent load in combobox its create new 3 columns

What I have tried:

<pre lang="vb"><pre> Public Sub getItemUnits(DGV As DataGridView, ItemID As Integer)
        Dim adp As New SqlClient.SqlDataAdapter("Select FirstUnit, SecondUnit, ThirdUnit from ItemsMainTbl where ItemID = '" & ItemID & "'", ConfigurationManager.ConnectionStrings("connSQLServer").ConnectionString)
        Dim ds As New DataSet
        adp.Fill(ds)
        Dim dt = ds.Tables(0)
        If dt.Rows.Count > 0 Then
            Dim dgvcc As DataGridViewComboBoxCell
            dgvcc = DGV.Rows(DGV.Rows.Count - 1).Cells(2)
            dgvcc.Items.Add(dt.Rows(0).Item("FirstUnit"))
            dgvcc.Items.Add(dt.Rows(0).Item("SecondUnit"))
            dgvcc.Items.Add(dt.Rows(0).Item("ThirdUnit"))
            DGV.ClearSelection()
            DGV.Rows(DGV.Rows.Count - 1).Cells(2).Selected = True
        End If


    End Sub

VB

  FrmManage_Store.ItemLoadGv.Rows.Add()
        FrmManage_Store.ItemLoadGv.Rows(FrmManage_Store.ItemLoadGv.Rows.Count - 1).Cells(0).Value = ItemsGv.CurrentRow.Cells(0).Value
        FrmManage_Store.ItemLoadGv.Rows(FrmManage_Store.ItemLoadGv.Rows.Count - 1).Cells(1).Value = ItemsGv.CurrentRow.Cells(1).Value
        ItemID = ItemsGv.CurrentRow.Cells(0).Value
FrmManage_Store.ItemLoadGv.Rows(FrmManage_Store.ItemLoadGv.CurrentRow.Index).Cells(2).DataGridView.DataSource = p4.Get_Units_By_ItemID(ItemID)

Posted 15-May-17 2:00am

khalid4775

Updated 17-May-17 5:38am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2017-05-15T09:54:00

Never build an SQL query by concatenating with user inputs, it is named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability.
SQL injection - Wikipedia[^]
SQL Injection[^]

khalid4775 · Answer 2 · 2017-05-17T05:38:00

i have fixed like so :

VB

<pre>      Public Function Get_Units_By_ItemID(DGV As DataGridView, ByVal ItemID As Integer) As DataTable
            Dim dt As New DataTable
            p.Get_Units_By_ItemID(dt, ItemID)
            If dt.Rows.Count > 0 Then
                Dim dgvcc As DataGridViewComboBoxCell
                dgvcc = DGV.Rows(DGV.Rows.Count - 1).Cells(2)
                dgvcc.Items.Add(dt.Rows(0).Item("UnitName"))
                dgvcc.Items.Add(dt.Rows(0).Item("UnitName1"))
                dgvcc.Items.Add(dt.Rows(0).Item("UnitName2"))
                DGV.ClearSelection()
                DGV.Rows(DGV.Rows.Count - 1).Cells(2).Selected = True
            End If
            Return dt
        End Function

Filling datagridview combobox

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0