Click here to Skip to main content
15,888,908 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
I have an object declared in the main (GUI) thread and instantiated from another thread. I require to access a member from it. However accessing a method of the object results in:

System.NullReferenceException: 'Object reference not set to an instance of an object.'

srv was null.
The following is the code resulting in the above error:


public partial class MainWindow : Window
{

     Thread t = null;
     ServerSpace.Server srv = null;
     bool serveractive = false;
    .
    .
    .
      private void start_MouseDown(object sender, MouseButtonEventArgs e)
      {
           if(!serveractive)
           {
                App.connectioninfo = new ServerSpace.ServerInfo(IPAdd.Text, 
                Int32.Parse(PRTNo.Text));

                 t = new Thread(() =>
                 {
                      srv = new ServerSpace.Server(App.connectioninfo)
                 });
                 t.Start();
           }
           else
           {
                    srv.stopserver();
                    MessageBox.Show("Server stopped.");
           }


       }
}


"serveractive" will be set true once "Server(ServerInfo)" constructor gets executed. The exception is thrown at "srv.stopserver()".

What correction should I proceed with in the above code ?

What I have tried:

I tried using "Application.Current.Dispatcher.Invoke", but the same error results.
Updated 28-May-17 20:35pm

1 solution

This is one of the most common problems we get asked, and it's also the one we are least equipped to answer, but you are most equipped to answer yourself.

Let me just explain what the error means: You have tried to use a variable, property, or a method return value but it contains null - which means that there is no instance of a class in the variable.
It's a bit like a pocket: you have a pocket in your shirt, which you use to hold a pen. If you reach into the pocket and find there isn't a pen there, you can't sign your name on a piece of paper - and you will get very funny looks if you try! The empty pocket is giving you a null value (no pen here!) so you can't do anything that you would normally do once you retrieved your pen. Why is it empty? That's the question - it may be that you forgot to pick up your pen when you left the house this morning, or possibly you left the pen in the pocket of yesterdays shirt when you took it off last night.

We can't tell, because we weren't there, and even more importantly, we can't even see your shirt, much less what is in the pocket!

Back to computers, and you have done the same thing, somehow - and we can't see your code, much less run it and find out what contains null when it shouldn't.
But you can - and Visual Studio will help you here. Run your program in the debugger and when it fails, VS will show you the line it found the problem on. You can then start looking at the various parts of it to see what value is null and start looking back through your code to find out why. So put a breakpoint at the beginning of the method containing the error line, and run your program from the start again. This time, VS will stop before the error, and let you examine what is going on by stepping through the code looking at your values.

But we can't do that - we don't have your code, we don't know how to use it if we did have it, we don't have your data. So try it - and see how much information you can find out!
 
Share this answer
 
Comments
[no name] 29-May-17 8:09am    
I thought the code were wrong in the threading part, I have declared an object in the main thread but instantiated on another thread. If the object was instantiated then why does it show the NullReferenceException when I call a method of that object ?
OriginalGriff 29-May-17 8:25am    
Don't "think" what it might be: use the debugger and find out!
Mike Niday 2-Jun-17 12:42pm    
How nice of you to take the time to write a detailed response to help the OP to learn how to solve the problem on his own. Such a refreshing break from the typical "RTFM" or "Do a search!" responses. Thumbs up!!

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900