Speed up retrieve image into picturebox

Question

1.00/5 (2 votes)

See more:

I'm currently working on windows form application which allow user to retrieve image after searching at textbox. The problem is the image is load very slow. How can I overcome this problem to speed up the loading? If anyone has suggestions for a faster way to retrieve these images, it would be greatly appreciated. Here is my code:

What I have tried:

C#

string baseFolder = @"\\\\jun01\\hr\\photo";
  string imgName =  "*" + textBoxEmplNo.Text  + "*.jpg";

  //Bool to see if file is found after checking all
  bool fileFound = false;

  DirectoryInfo di = new DirectoryInfo(baseFolder);
  foreach (var file in di.GetFiles(imgName, SearchOption.AllDirectories))

   {
    pictureBox1.Visible = true;
    pictureBox1.Image = Image.FromFile(file.FullName);

    fileFound = true;
    break;
   }

    if (!fileFound)
   {
    pictureBox1.Visible = true;
    pictureBox1.Image = Image.FromFile(@"\\\\jun01\\hr\\photo\\No-image-
    found.jpg");
   }

Posted 30-May-17 16:17pm

Hamizah AHMAD TALHAH

Updated 31-May-17 17:56pm

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2017-05-30T16:48:00

Ummmm.... you might want to figure our how to use the debugger so you can follow what your code is really doing.

You're not loading a single image. Your code is loading into a PictureBox (that can only display one image at a time), every image in a folder and the entire subtree under that folder, one at a time.

There is really no way to speed that up because GetFiles is searching the root folder and then searching the entire subtree of that folder, building a list of "*.jpg" files. This can be a time consuming process, especially on a network share like you're doing.

Once that is done, you're looping through each of those returned file paths and telling a PictureBox (which can only display one image at a time) to load and then forget about every one of those files. Only the last filepath in the list returned by GetFiles is going to be displayed.

I have no idea what you're really trying to do with this code.

Oh, and it leaks resources like crazy too. You have to Dispose each Bitmap object you create and you're not doing that.

Richard Deeming · Answer 2 · 2017-05-31T11:52:00

The DirectoryInfo.GetFiles method finds all matching files and loads them into an array before returning control to your code. Your code then reads the first matching file, and ignores the rest.

Try using EnumerateFiles instead; that returns each file as it's found, without waiting for the search to complete:

C#

bool fileFound = false;
DirectoryInfo di = new DirectoryInfo(baseFolder);
foreach (var file in di.EnumerateFiles(imgName, SearchOption.AllDirectories))
{
    pictureBox1.Visible = true;
    pictureBox1.Image = Image.FromFile(file.FullName);
    fileFound = true;
    break;
}
if (!fileFound)
{
    ...
}

You could even use LINQ to simplify that:

C#

DirectoryInfo di = new DirectoryInfo(baseFolder);
FileInfo file = di.EnumerateFiles(imgName, SearchOption.AllDirectories).FirstOrDefault();
if (file != null)
{
    pictureBox1.Visible = true;
    pictureBox1.Image = Image.FromFile(file.FullName);
}
else
{
    ...
}

Hamizah AHMAD TALHAH · Answer 3 · 2017-05-31T17:56:00

Solution 3

I already try it but still slow. :(

Posted 31-May-17 17:56pm

Hamizah AHMAD TALHAH

Comments

Richard Deeming 1-Jun-17 11:57am

But you've obviously solved the problem.

How do I know? Because you've posted this as a "solution", and then accepted it, marking your problem as "solved".

Delete this fake "solution".

Hamizah AHMAD TALHAH 2-Jun-17 3:07am

Sorry. Maybe I accidentally click that.

Speed up retrieve image into picturebox

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0