There was an error parsing the query. [ Token line number = 1, token line offset = 115, token in error = ) ] I have the following line of code

Question

1.00/5 (1 vote)

See more:

SqlCeConnection stock_in = new SqlCeConnection(@"Data Source=C:\\Users\\Prime Computer\\Documents\\Visual Studio 2010\\Projects\\STOCK MANAGEMENT\\STOCK MANAGEMENT\\StockManagement.sdf");

           stock_in.Open();
           SqlCeCommand stock_in_command = new SqlCeCommand("INSERT INTO stock_in(name,code,type,category,price,packing,power,quantity)VALUES('" + comboBox1.SelectedText + "','" + comboBox2.SelectedText + "','" + comboBox3.SelectedText + "','" + comboBox4.SelectedText + "','" + textBox1.Text + "','" + textBox2.Text + "','" + textBox3.Text + "','" + textBox4.Text + "',)",stock_in);
           stock_in_command.ExecuteNonQuery();
           stock_in.Close();
           MessageBox.Show("RECORD IS SAVED");

What I have tried:

what is wrong with my code i have also tried to use combobox.text property but still it is giving the same error

Posted 5-Jun-17 9:09am

Member 13241999

Updated 5-Jun-17 9:48am

Add a Solution

Comments

Richard Deeming 6-Jun-17 9:23am

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Don't ignore it. One stray quote in one of your textboxes - whether accidental or deliberate - can destroy your database.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Michael_Davies · Accepted Answer · 2017-06-05T09:47:00

Solution 1

Remove the comma before the closing parenthesis, it means there is another value and there is not;

"','" + textBox1.Text + "','" + textBox2.Text + "','" + textBox3.Text + "','" + textBox4.Text + "',)",stock_in);

Also please look at using parameterised queries rather than concatenating strings, leaving yourself open to SQL injection and it is harder to find problems when they occur.

Posted 5-Jun-17 9:47am

Michael_Davies

Comments

Member 13241999 5-Jun-17 16:06pm

thanks for pointing out comma mistake but after removing the comma it show the following error now "The specified table does not exist. [ stock_in ]" even the table is there

Michael_Davies 5-Jun-17 16:33pm

You'll need to show the schema for anyone to be able to answer that.

Member 13241999 5-Jun-17 16:39pm

hmmm you are right but unfortunately print screen button of my laptop is not working can i have your whatsapp/imo/facebook so i can send you table schema picture/ video

Member 13241999 5-Jun-17 16:40pm

Reply Modify the comment. Delete the comment.
i want to insert data in table say "stock_in" i am building an app for medical store in which i have mutliple forms and each form is having using database which is in my case "medicalstoremanagement.sdf" which include talbes like " product,customer,company,orders,stock in, stock out, etc the form/table for which i am using the above stated query is stock_in the form link with it is using values from two tables product and customer i have link the comboboxes with combobox1 which is using value from a datasource name addproductbindingsource.

Patrice T · Accepted Answer · 2017-06-05T09:48:00

Not directly a solution to your question, but another problem you have.
Never build an SQL query by concatenating with user inputs, it is a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]

Secondary problem of the way you build the query:
You are given a very precise error message, but since we have no way to know what is your exact query, we can't use the error message.

C#

SqlCeCommand stock_in_command = new SqlCeCommand("INSERT INTO stock_in(name,code,type,category,price,packing,power,quantity)VALUES('" + comboBox1.SelectedText + "','" + comboBox2.SelectedText + "','" + comboBox3.SelectedText + "','" + comboBox4.SelectedText + "','" + textBox1.Text + "','" + textBox2.Text + "','" + textBox3.Text + "','" + textBox4.Text + "',)",stock_in);

But sometimes one can get lucky when the error is so huge. Have a mppl at the end of query and remove the comma.