How to get one user id that is logged in and its score

Question

0.00/5 (No votes)

See more:

public partial class ScorePage : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        if (Session["UserID"]==null)
        {
            Response.Redirect("LoginPage.aspx");
        }
       
        Score_Page();
     
    }
    private void Score_Page()
    {
        string id = Convert.ToString(Session["UserID"]);
        string query = "SELECT UserId, SUM(AnswerResult)Score FROM t_AnswerSheet group by  UserId";
        string connection = "server=sv01;database=testdb;uid=sa;password=****";

        SqlConnection a = new SqlConnection(connection);
        a.Open();
        SqlCommand b = new SqlCommand(query, a);
        DataTable c = new DataTable();
        SqlDataAdapter sda = new SqlDataAdapter(b);
        sda.Fill(c);
        a.Close();
        GridView1.DataSource = c;
        GridView1.DataBind();
    }

string id = Convert.ToString(Session["UserID"]);
       string query = "SELECT UserId, SUM(AnswerResult)Score FROM t_AnswerSheet group by  UserId";
       string connection = "server=*****;database=testdb;uid=***;password=****";

as in this part of code i am using session to get UserId from UserLoging Table but wasn't able to get User id into select command as Whenever user login it send respective id to score page along with score of that id ...but here em getting all Id and their result score. So i need just Id that get login and respective score to that Id

What I have tried:

<pre>public partial class ScorePage : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {
        if (Session["UserID"]==null)
        {
            Response.Redirect("LoginPage.aspx");
        }
       
        Score_Page();
     
    }
    private void Score_Page()
    {
        string id = Convert.ToString(Session["UserID"]);
        string query = "SELECT UserId, SUM(AnswerResult)Score FROM t_AnswerSheet group by  UserId";
        string connection = "server=***;database=testdb;uid=**;password=*****";

        SqlConnection a = new SqlConnection(connection);
        a.Open();
        SqlCommand b = new SqlCommand(query, a);
        DataTable c = new DataTable();
        SqlDataAdapter sda = new SqlDataAdapter(b);
        sda.Fill(c);
        a.Close();
        GridView1.DataSource = c;
        GridView1.DataBind();
    }

Posted 21-Jun-17 20:31pm

Member 11644373

Updated 21-Jun-17 21:09pm

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2017-06-21T20:48:00

You need to add a WHERE clause to your SQL:

C#

string id = Convert.ToString(Session["UserID"]);
string query = "SELECT UserId, SUM(AnswerResult)Score FROM t_AnswerSheet WHERE UserId=@ID GROUP BY UserId";
string connection = "server=sv01;database=testdb;uid=sa;password=[REDACTED]";

using (SqlConnection con = new SqlConnection(connection))
   {
   con.Open();
   using (SqlCommand cmd = new SqlCommand(query, con))
      {
      cmd.Parameters.AddWithValue("@ID", id);
      ...

A couple of other things to make your life better:
1) Don't hardcode connection strings - always use a configuration file or similar.
2) Never post database ID and password combinations online...
3) Don't use the SA user - create users which have "just enough" permissions to do the job - it reduces the risks to the rest of your database(s), since SA can do anything at all!
4) Don't use single character variable names - it makes your code harder to read, and that means less maintainable in future (and you will spend a lot of time looking at code you or someone else has written a while a go, and working out how it works - or doesn't)
5) Always Dispose database connections, commands, adapters, etc: they are scarce resources and not doing so can make your app crash unpredictably.