Panels wont show when button is skipped.

Question

0.00/5 (No votes)

See more:

I got a splitcontainer panel(panel 1 contains 7 buttons, panel2 from split container contains panels 3-9)

When button 1 is clicked it will show panel 3, button 2 when clicked will show panel 4.... but every time I skip a button it will not show the panel of the clicked button. ex. I clicked button 1 it'll show panel 3 but when I skip button 2 and click button 3 it 3 it wont display panel 5... every time I skip buttons it wont show the designated panels... #WindowsAppForm C#

What I have tried:

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace kennyrogers
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            splitContainer1.Panel2.Visible = true;
            panel3.Visible = true;
            panel4.Visible = false;
        }

        private void button2_Click(object sender, EventArgs e)
        {
            panel4.Visible = true;
            panel5.Visible = false;
        }

        private void button3_Click(object sender, EventArgs e)
        {
            panel5.Visible = true;
            panel6.Visible = false;
        }

        private void button4_Click(object sender, EventArgs e)
        {
            panel6.Visible = true;
            panel7.Visible = false;

        }

        private void button5_Click(object sender, EventArgs e)
        {
            panel7.Visible = true;
            panel8.Visible = false;
        }

        private void button6_Click(object sender, EventArgs e)
        {
            panel8.Visible = true;
            panel9.Visible = false;
        }

        private void button7_Click(object sender, EventArgs e)
        {
            panel9.Visible = true;
            panel6.Visible = false;
        }
    }
}

Posted 22-Jul-17 17:05pm

Member 13296680

Updated 23-Jul-17 6:37am

Bryian Tan

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graeme_Grant · Answer 1 · 2017-07-22T18:23:00

You have answered your own question. If you look at the code, not all panel visibility states are managed for each button. eg: button6 code does not change the panel1 visibility state, and so on...

You can either use the State Design Pattern[^] or a shared method and switch statement. But for something simple like above, you could do the following:

C#

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();
        SetState(States.first);
    }

    private void button1_Click(object sender, EventArgs e)
    {
        SetState(States.first);
    }

    private void button2_Click(object sender, EventArgs e)
    {
        SetState(States.second);
    }

    private void button3_Click(object sender, EventArgs e)
    {
        SetState(States.third);
    }

    private void button4_Click(object sender, EventArgs e)
    {
        SetState(States.forth);
    }

    private void button5_Click(object sender, EventArgs e)
    {
        SetState(States.fifth);
    }

    private void button6_Click(object sender, EventArgs e)
    {
        SetState(States.sixth);
    }

    private void button7_Click(object sender, EventArgs e)
    {
        SetState(States.seventh);
    }

    private void button8_Click(object sender, EventArgs e)
    {
        SetState(States.eighth);
    }

    private void button9_Click(object sender, EventArgs e)
    {
        SetState(States.nineth);
    }

    private void SetState(States state)
    {
        panel1.Visible = state == States.first;
        panel2.Visible = state == States.second;
        panel3.Visible = state == States.third;
        panel4.Visible = state == States.forth;
        panel5.Visible = state == States.fifth;
        panel6.Visible = state == States.sixth;
        panel7.Visible = state == States.seventh;
        panel8.Visible = state == States.eighth;
        panel9.Visible = state == States.nineth;
    }
}

enum States
{
    first,
    second,
    third,
    forth,
    fifth,
    sixth,
    seventh,
    eighth,
    nineth
}

** UPDATE: If you need to have more than one panel shown on a button click, you could use enum bitwise operation with the Flags attribute. Eg:

C#

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();
        SetState(States.None);
    }

    private void button1_Click(object sender, EventArgs e)
    {
        SetState(States.first | States.third);
    }

    private void button2_Click(object sender, EventArgs e)
    {
        SetState(States.second);
    }

    private void button3_Click(object sender, EventArgs e)
    {
        SetState(States.third | States.second);
    }

    private void SetState(States state)
    {
        panel1.Visible = (state & States.first) != 0;
        panel2.Visible = (state & States.second) != 0;
        panel3.Visible = (state & States.third) != 0;
        // and so on...
    }
}

[Flags]
internal enum States
{
    None = 0,
    first = 1,
    second = 2,
    third = 4,
    forth = 8,
    fifth = 16,
    sixth = 32,
    seventh = 64,
    eighth = 128,
    nineth = 256
}

BillWoodruff · Answer 2 · 2017-07-23T06:37:00

Note 0. Note that the Panel Control in WinForms is not a full-featured Window with a handle: it does not receive Key events, it will not become Focused as other Controls will. The code in the second example shows one way to get around this by setting Focus to some other Control inside the Panel which is a "full-windowed Control."

The simplest way to do this is to, at design-time, select all your Buttons that will do something to the Panels, open the Properties explorer, select Events, and double-click on the 'Click event: now VS writes the Click EventHandler for you, and all you have to do is write a Switch statement:

private void button1_Click_1(object sender, EventArgs e)
{
    switch ((sender as Button).Name)
    {
        case "buttonl":
            splitContainer1.Panel2.Visible = true;
            panel3.Visible = true;
            panel4.Visible = false;
            break;
        case "button2":
            // do whatecver
            break;
        
        // and so on ...

        default:
            break;
    }
}

Note: 1. A slightly more complex technique: map the Buttons in the left SplitterPanel to the Panels in the right SplitterPanel using a Dictionary where the Key is a Button, and the Value is an executable function that takes a Panel as a parameter: Dictionary<Button, Action>

public Dictionary<Button, Action> ButtonToAction;

private void Form1_Load(object sender, EventArgs e)
{ 
    ButtonToAction = new Dictionary<Button, Action>
    {
        { button1, () => PanelSelect(panel3)},
        { button2, () => PanelSelect(panel4)},
        { button3, () => PanelSelect(panel5)},
        { button4, () => PanelSelect(panel6)}
    };
}

private void PanelSelect(Panel panel)
{
    // see Note #0 above
    ActiveControl = panel.Controls[0];
    panel.Controls[0].Focus();

    switch (panel.Name)
    {
        case "panel3":
            splitContainer1.Panel2.Visible = true;
            panel3.Visible = true;
            panel4.Visible = false;
            break;
        case "panel4":
            break;
        case "panel5":
            break;
        case "panel6":
            break; 
        default:
            break;         
    }
}

Panels wont show when button is skipped.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0