How do I get the max value from SQL and insert it to a data row

Question

0.00/5 (No votes)

See more:

using sql SERVER 2014
I have table address contains addID PK identity(1,1), city varchar()
table client contains CLNAME varchar(), clID PK, addID foreign key from previous table.
i have a form that allows me to add new address with a new client
the address is added correctly and giving it a new addID automatically (IDENTITY (1,1)) but an error occurs since the addID in client is not inserted automatically
i need to get the max value of addID from table address and add it to my data-row in a data set containing table "client" in order to update the data base

What I have tried:

VB

sqlconn = conxn()
        Dim dset As New DataSet("client")
        Dim dadpt As New SqlDataAdapter("select * From client", sqlconn)
        dadpt.Fill(dset, "client")
        Dim dsADRS As New DataSet("adrs")
        Dim daADRS As New SqlDataAdapter("SELECT MAX(addID) FROM addres ", sqlconn)
        daADRS.Fill(dsADRS, "adrs")
        sen  = 
 

        sqlconn.Close()
 
        Dim cmdBuilder As SqlCommandBuilder = New SqlCommandBuilder(dadpt)
        Dim dr As DataRow
        dr = dset.Tables("client").NewRow()
 
        dr("name") = name
        dr("fname") = fname
      
        dr("addID") = Convert.ToDecimal(sqls)
        dset.Tables("lawyer").Rows.Add(dr)
        dadpt.Update(dset, "lawyer")

Posted 20-Aug-17 14:12pm

Member 13369800

Updated 21-Aug-17 9:46am

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 20-Aug-17 22:41pm

I recommend against using IDENTITY, particularly in cases such as this.
One option is to use a SEQUENCE instead.
Either way, you need to INSERT the parent row prior to the child row.

And generally, please learn better database techniques.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2017-08-21T08:15:00

Solution 1

You do not want to SELECT MAX. Instead, right after doing the insert into the address table do

SQL

SELECT @newAddID = SCOPE_IDENTITY()  -- this gets the most recently inserted Identity number

...


INSERT INTO client (field1, ship_to_add_id, ...)
VALUES (@field1, @newAddID...)

Posted 21-Aug-17 8:15am

ZurdoDev