Stuck on this please help

Question

1.00/5 (2 votes)

See more:

Define a function that takes m and n integers as input and print odd numbers between m and n

C++

vector < int > oddNumbers(int m,int n)
{


}

What I have tried:

C++

vector <int> oddNumbers(int l,int r)
    
        {
        oddNumbers.push_back();
    cout<<"Enter second number";
            oddNumbers.push_back();

        for(unsigned int i=l+1;i<r;i++)
        {
            if (i%2!=0)
                oddNumbers.push_back()
                cin>>i;
        }

Posted 20-Sep-17 16:45pm

Member 13420756

Updated 21-Sep-17 15:31pm

PIEBALDconsult

v2

Add a Solution

Comments

Patrice T 20-Sep-17 23:37pm

Where are you stuck?
Advice: reread your requirement.

Member 13420756 21-Sep-17 0:05am

at the pushback statements

Patrice T 21-Sep-17 0:07am

why you want to use pushback statements in first place ?

Member 13420756 21-Sep-17 0:24am

how can we do it or else can u please tell me.. i m a beginner

Member 13420756 21-Sep-17 0:25am

the vector function was predefined in the question. i have to use it compulsarily

Patrice T 21-Sep-17 0:27am

What are you asked to do ?
Where did they asked to return a vector ?

Member 13420756 21-Sep-17 0:34am

So I am just told to complete this function for the problem
vector < int > oddNumbers(int m,int n)
{

}

Not write the entire program
This function should accept two nos m and n
and display the odd nos between m and n

Patrice T 21-Sep-17 0:40am

Try to fill this one instead
void oddNumbers(int m,int n)
{

}
you are bot asked to return any thing.

Richard MacCutchan 21-Sep-17 4:04am

Why are you using a vector when the instructions state: "and print odd numbers"?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2017-09-20T23:30:00

Solution 2

If you have to fill the proposed function, namely

Quote:
vector < int > oddNumbers(int m,int n)
{
}

Then

C++

vector < int > oddNumbers(int m,int n)
{
  vector<int> v;
  if ( m % 2 == 0) ++m;

  while ( m <= n )
  {
    v.push_back(m);
    m+=2;
  }
  return  v;
}

Posted 20-Sep-17 23:30pm

CPallini

KarstenK · Answer 2 · 2017-09-20T23:00:00

Solution 1

You dont need such vector as return. The code should really be easy:

C++

void printOddNumbers(int l, int r)
{
 for( int i = l; i < r; i++)
 {
   if( i % 2 == 0 ) 
   {
     cout << i;
   }
 }
}

The code only work if r > l. Think what error handling or "healing" to do, if l < r.

Posted 20-Sep-17 23:00pm

KarstenK

Comments

CPallini 21-Sep-17 5:19am

It's rather odd, but that doesn't work even if l<r.

Patrice T · Answer 3 · 2017-09-21T15:31:00

Advice: use proper indentation to see code structure, it helps reading and can highlight some problems. See the cin.

C++

vector <int> oddNumbers(int l,int r)

{
	oddNumbers.push_back();
	cout<<"Enter second number";
	oddNumbers.push_back();

	for(unsigned int i=l+1;i<r;i++)
	{
		if (i%2!=0)
			oddNumbers.push_back()
		cin>>i;
	}
}

Problems in your code:

C++

vector <int> oddNumbers(int l,int r)

{
	// where did you defined/declared oddNumbers ?
	oddNumbers.push_back(); // you have to tell what value to want to push back
	cout<<"Enter second number"; // which second number ?
	oddNumbers.push_back(); // you have to tell what value to want to push back

	for(unsigned int i=l+1;i<r;i++)
	{
		if (i%2!=0)
			oddNumbers.push_back() // a ; is missing here
		// you want to output i
		// because of not using {}, the cin is not in test
		cin>>i;
	}
	// you code do not return anything.
}