Downloading the file when clicking other button

Question

1.00/5 (1 vote)

See more:

im having problem on my code whenever i click the linkbutton(download) to download the uploaded file and when i click other button on the page still it downloads the file that i uploaded and here's my code

lblFile.Text = Issue.FileName;

        if (lblFile.Text != "")
        {
            trAttachedFile.Visible = true;
            lbtnDownload.PostBackUrl = "~/Download.aspx?file=" + lblFile.Text;
        }
        else
        {
            trAttachedFile.Visible = false;
        }

And here's the Download.aspx code behind

protected void Page_Load(object sender, EventArgs e)
    {

        if (!string.IsNullOrEmpty(Request.QueryString["file"]))
        {
            DownloadID = Request.QueryString["file"];
            if (StartDownload() == true)
            {
                lblMessage.Text = "Your download should start shortly";
            }
            else
            {
                lblMessage.Text = "Download File does not exist";
            }
        }

private bool StartDownload()
    {
        if (DownloadID != "")
        {
            string downloadPath = WebConfigurationManager.AppSettings["SubPic"].ToString() + DownloadID;
            FileInfo downloadFile = new FileInfo(downloadPath);

            if (downloadFile.Exists)
            {
                Response.Clear();
                Response.AddHeader("Content-Disposition", "attachment; filename=" + downloadFile.Name);
                Response.AddHeader("Content-Length", downloadFile.Length.ToString());
                Response.ContentType = "application/octet-stream";
                Response.WriteFile(downloadFile.FullName);
                Response.End();
                return true;
            }
        }
        return false;
    }

and here's the linkbutton

<tr runat="server" id="trAttachedFile">
            <td>
                <asp:Label runat="server" Text="File Attachment:" />
            </td>
            <td colspan="2">
                <asp:Label runat="server" ID="lblFile" />
                 
                <asp:LinkButton runat="server" Text="Download" ID="lbtnDownload" CssClass="lbtnDownload" />
            </td>
            <td> </td>
        </tr>

What I have tried:

Any suggestion guys on my code. Thanks in advance

Posted 8-Oct-17 8:49am

Member 13427032

Updated 8-Oct-17 20:45pm

Add a Solution

Comments

Richard Deeming 10-Oct-17 12:15pm

REPOST
This is the same (solved) question you asked last week:
https://www.codeproject.com/Questions/1208692/When-clicking-the-linkbutton-download-and-I-click[^]

The answer hasn't changed in the last 9 days!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

GKP1992 · Accepted Answer · 2017-10-08T20:45:00

Do not write the download logic in your Page_Load event, since it will be called everytime the page is loaded, and according to your logic, will download a file if the request has the "File" key.

Write the logic in the LinkButton.Click event of the lbtnDownload. This will restrict the download action to the click event of the button and won't download every time your page is loaded.