Learning how to use array in C

Question

0.00/5 (No votes)

See more:

So I have this problem where it should look like this:

Team: A/B
Player No: 1-12
Points:

Winner is Team A/B
Player of the Game No.%d from Team A.
Player of the Game No.%d from Team B.

#include <stdio.h>


int
main (void)
{
	char team, another;
	int teamA[12], teamB[12], pointA=0, pointB=0, NoA=0, NoB=0, points;
	int potgA=0, potgB=0;
	
		do {
			printf("Team :");
			scanf(" %c", &team);
			switch (team)
			{
				case 'a':
				case 'A':
					printf("\nPlayer No. :");
					scanf("%d", &teamA[NoA]);
					printf("\nPoints :");
					scanf("%d", &points);
					pointA = pointA + points;
					if(points>potgA)
					{
						points = teamA[NoA];
						potgA = teamA[NoA];
					}
					break;
				case 'b':
				case 'B':
					printf("\nPlayer No. :");
					scanf("%d", &teamB[NoB]);
					printf("\nPoints :");
					scanf("%d", &points);
					pointB = pointB + points;
					if(points>potgB)
					{
						points = teamB[NoB];
						potgB = teamB[NoB];
					}
					break;
			}
			printf("\nAnother Player? :");
			scanf(" %c", &another);
		}
		while(another == 'y' || another == 'Y');
		
		if(pointA == pointB)
			printf("\nDraw");
		else if(pointA > pointB)
			printf("\nWinnder is Team A");
		else
			{
			printf("\nWinner is Team B");
			}
		printf("\nPlayer of the Game No.%d from Team A", potgA);
		printf("\nPlayer of the Game No.%d from Team B", potgB);
		
}

now the problem that I'm having is I can't get the Player of the Game to work properly.

What I have tried:

I haven't really tried as much because I can't really figure out what's wrong but I think that it is something in the "IF" section of both cases.
Am I missing another variable?
I can't code this thought.
If (player number's point is > the largest point on the team)
potgA = Player number

Posted 11-Oct-17 1:10am

Member 13396113

Updated 11-Oct-17 1:17am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-10-11T01:17:00

Solution 1

Simple: you are recording the points they scored, but not who they are.

if(points>potgB)
{
    points = teamB[NoB];
    potgB = teamB[NoB];
}

Tells you the highest points, yes. But you don't record NoB (or NoA) anywhere, so you have no idea later which player it was.
The way I would do it it not to store points or potG but player - the NoB value - instead. Because you can use that at any time to access the player point information.

Posted 11-Oct-17 1:17am

OriginalGriff

Comments

Member 13396113 11-Oct-17 7:33am

I honestly can't figure it out completely.
Now I'm thinking I need a loop for the storing player no. into the array slot.
don't i need another variable just to store highest point?
if(points > highest point)
potg = noB

OriginalGriff 11-Oct-17 7:46am

Why would you need another loop? You have a loop for finding the highest points, yes?
And since the points come from an array which you access via a player number, if you store the player number you can access his points at any time later but looking in the array at that player number.
You can use a separate variable to store the "current highest points" just as you are now, but that's just an in-loop shortcut. The highest points comes from the points array[number of the player who scored it] into your points variable anyway!

Member 13396113 11-Oct-17 8:12am

I'm really sorry if I'm being a pain because this whole thing is so confusing to me.

Would it be okay to have an array for player numbers and another array for the points, that way i can do a loop where it finds the highest point?

OriginalGriff 11-Oct-17 8:24am

Well...yes. But why would you need one?
You have an array of points-by-player-number (you call it teamA and teamB) and the player number indexes into that to return the points scored by that player.
So if you store the player number that scored the highest points in a variable called hiPlayerA and hiPlayerB (by saying hiPlayerA = NoA;) you can access the actual points value via teamA:
teamA[hiPlayerA]

See what I mean?

Member 13396113 11-Oct-17 8:24am

So I did this and it worked for me. Was just wondering if you could double check if it's solid or not. Again I apologize for being a noob. Lol

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>

int
main (void)
{
	char team, another;
	int teamA[12], teamB[12], pointA=0, pointB=0, NoA, NoB, hipointA=0, hipointB=0;
	int potgA=0, potgB=0;
	
		do {
			printf("Team :");
			scanf(" %c", &team);
			switch (team)
			{
				case 'a':
				case 'A':
					printf("\nPlayer No. :");
					scanf("%d", &NoA);
					printf("\nPoints :");
					scanf("%d", &teamA[NoA]);
					pointA = pointA + teamA[NoA];
					if(teamA[NoA] > hipointA)
						potgA = NoA;
						hipointA = teamA[NoA];
					break;
				case 'b':
				case 'B':
					printf("\nPlayer No. :");
					scanf("%d", &NoB);
					printf("\nPoints :");
					scanf("%d", &teamB[NoB]);
					pointB = pointB + teamB[NoB];
					if(teamB[NoB] > hipointB)
					{
						potgB = NoB;
						hipointB = teamB[NoB];
					}
					break;
			}
			printf("\nAnother Player? :");
			scanf(" %c", &another);
		}
		while(another == 'y' || another == 'Y');
		
		if(pointA == pointB)
			printf("\nDraw");
		else if(pointA > pointB)
			printf("\nWinnder is Team A");
		else
			{
			printf("\nWinner is Team B");
			}
		printf("\nPlayer of the Game No.%d from Team A", potgA);
		printf("\nPlayer of the Game No.%d from Team B", potgB);
		
}

OriginalGriff 11-Oct-17 8:25am

Yay!
Well done!

Member 13396113 11-Oct-17 8:36am

Thank you!
Did you try to run it on yourself and got it to work as well?
Just wanted to make sure that its foolproof

OriginalGriff 11-Oct-17 8:40am

:laugh:
No, I'm on a tablet ATM and don't have access to a C compiler, much less one that would create apps that would run on this!

Member 13396113 11-Oct-17 8:41am

I see but if you don't mind could you just check the program and maybe give me tips if theres a way to simplify it and all that.

OriginalGriff 11-Oct-17 9:08am

Well ... there are some nasties in there, and some duplication.
Nasties: What happens if I enter player number 13? Or 104? Or even "seven"?
You really shouldn't trust users to get it right - you need to check what they enter everytime, or your app will crash and burn.

On a related note, why does the user have to enter a player number at all? you really need values for every player, so isn't it better (and a lot easier for the user) to prompt the user for player number 0, then 1, then 2, then 3, ... instead of expecting them to enter it at all? And isn't it easier to enter the whole of one team, then the whole of the other?

Duplication: your two cases are identical except for the place they store things - perhaps a separate function that you call twice and pass variables into would be a better idea? That way, if you make changes you only need to make them in one place...

Member 13396113 11-Oct-17 11:20am

I guess i should put like a user instruction of some sort.

as for just asking the user to input points for players. It could also happen that other players did not make any points.

Yes, i get the duplication. It's just that im still a beginner and i still haven't really perfected calling a separate functions. Especially with this one where there are different variables for each cases.