Pushing objects in an array

Question

0.00/5 (No votes)

See more:

I have this code where starred_messages is an empty array and starred_id is an empty object.
On the click function I am setting the object's key and value and pushing it in the array.

The first time it is okay but on the next click function instead of adding the new object just to the next index of the array. It is also adding to the previous indexes.

Here's what the array looks like the first time:

0: {msg_92: "<span class="chat-img pull-left"><img src="http://…on glyphicon-time"></span>26 Dec, 6:18 pm</small>"}

Here's what the array looks like the on the second click:

0: {msg_92: "<span class="chat-img pull-left"><img src="http://…on glyphicon-time"></span>26 Dec, 6:18 pm</small>"}, {msg_10: "<span class="chat-img pull-left"><img src="http://…on glyphicon-time"></span>26 Dec, 6:18 pm</small>"}
 1: {msg_92: "<span class="chat-img pull-left"><img src="http://…on glyphicon-time"></span>26 Dec, 6:18 pm</small>"}, {msg_10: "<span class="chat-img pull-left"><img src="http://…on glyphicon-time"></span>26 Dec, 6:18 pm</small>"}

Notice that it added the second object also to the 0th index and the 1st index contains the first object.

I want to add the objects on different indexes.

What I have tried:

var starred_messages = [];
var starred_id = {};

$(document).on('click', '.star', function () {
   var starred_msg_id = $(this).parent().attr('id');
   var starred_msg = $(this).parent().html();
   starred_id[starred_msg_id] = starred_msg;						
   starred_messages.push(starred_id);
});

Posted 26-Dec-17 23:53pm

SL-A-SH

Updated 27-Dec-17 1:13am

Add a Solution

2 solutions

Solution 2

Quote:
The first time it is okay but on the next click function instead of adding the new object just to the next index of the array. It is also adding to the previous indexes.

In fact behind the hood, you push a pointer to object in array.
Next time, you push again a pointer to same object. And since array contain only pointers to 1 object, any change done to the object appear every where in the array.

To avoid this problem, you need to duplicate/copy the object before pushing in array.

Posted 27-Dec-17 1:13am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2017-12-27T00:26:00

use function as class[^] object instead of a literal object
if you use literal object[^] the value will get over written every time when the same key is accessed.

refer this example;

function clsMsg(id, msg) {
         this.id = id;
         this.msg = msg;
     }

     var starred_messages = [];
     var starred_id = {};
     var starred_msg_id = 1
     var starred_msg = 'one'
     var item1 = new clsMsg(starred_msg_id, starred_msg);
     starred_messages.push(item1);

     var starred_msg_id = 1
     var starred_msg = 'two'
     var item2 = new clsMsg(starred_msg_id, starred_msg);
     starred_messages.push(item2);

     for (var i = 0; i < starred_messages.length; i++) {
         var item = starred_messages[i];

         console.log('id =' + item.id + ",  message =" + item.msg);
         // 1  one
         // 1 two
     }