I am using dbo.split method in SQL server to pass values to stored procedure as input parameter but it is giving wrong output

Question

0.00/5 (No votes)

See more:

I am using dbo.split method in sql server to pass values to stored procedure as input parameter but it is giving wrong output

My query is as

select * from Fin where Company in (select Company  from  dbo.Split('GHCL LTD,GODREJ INDUSTRIES LTD',','))

where

'GHCL LTD,GODREJ INDUSTRIES LTD'

are company names.

but it giving datafrom all company present in database

What I have tried:

select * from Fin where Company in (select Company  from  dbo.Split('GHCL LTD,GODREJ INDUSTRIES LTD',','))

Posted 18-Jan-18 21:03pm

paul_vin

Updated 19-Jan-18 5:09am

Add a Solution

3 solutions

Solution 1

Its better go for

GetColumnValue

function in sql.

Split function by comma in SQL Server 2008 - Stack Overflow[^]

A suggestion for you is that please don't post questions with organization names instead please add X,Y Z like this.

Posted 18-Jan-18 21:16pm

debasish mishra

Updated 18-Jan-18 21:18pm

v2

Solution 2

check my Tip, it might help you
How to Query Comma Separated Value Column in SQL[^]

Posted 18-Jan-18 21:39pm

Karthik_Mahalingam

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2018-01-19T05:09:00

At a guess, your custom dbo.Split function doesn't return a column called Company.

Which means that the Company column within your inner query is actually a reference to the Company column from your outer query.

Making your query equivalent to:

SQL

select * from Fin where Company = Company

That will return all records where the Company column is not NULL.

Find out the name of the column returned from your dbo.Split function, and use that:

SQL

select * from Fin where Company in (select Value from dbo.Split('GHCL LTD,GODREJ INDUSTRIES LTD', ','))

NB: If you're using SQL 2016 or higher, you can use the built-in STRING_SPLIT[^] function, which returns a single column called value.