Trying to update SQL query in ASP.NET but no errors, no update

Question

0.00/5 (No votes)

See more:

i am trying to update user profile details using update query in asp.net. But no update also no error showing. i am trying from 2 days to over come this problem. please help me. my code is here:

What I have tried:

con.Open();

method 1:
    id is primary key in sql server database.

        string cmd = "UPDATE login SET firstname=@fname, lastname=@lname, username=@username, email=@email, phone=@phone, gender=@gender, professionality=@pro where id=@id";
        SqlCommand sql = new SqlCommand(cmd,con);
        sql.Parameters.AddWithValue("@id",id);
        sql.Parameters.AddWithValue("@fname", fname.Text);
        sql.Parameters.AddWithValue("@lname", lname.Text);
        sql.Parameters.AddWithValue("@username", username.Text);
        sql.Parameters.AddWithValue("@email", email.Text);
        sql.Parameters.AddWithValue("@phone", phone.Text);
        sql.Parameters.AddWithValue("@gender",gender.SelectedItem+"");
        sql.Parameters.AddWithValue("@pro", pro.Text);
        sql.ExecuteNonQuery();
        con.Close();


method 2:
         here session["user"] is not primary key. but username column having unique data.

        con.Open();
        SqlCommand cmd = new SqlCommand("update login set firstname='" + fname.Text + 
        "',lastname='" + lname.Text + "'username='" + username.Text + "',email='" + 
        email.Text + "',phone='" + phone.Text + "',gender='" + gender.SelectedItem + 
        "',professionality='" + pro.Text + "' where username='"+Session["user"]+"'", 
        con);
        cmd.ExecuteNonQuery();
        con.Close();

Posted 2-Feb-18 0:24am

Mukthahar Shaik

Updated 2-Feb-18 0:53am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-02-02T00:33:00

Don't use method 2. Never use method 2. Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

If your code is not getting an error but the database is not getting updated, then that means the UPDATE WHERE clause matched no rows.
Why not? Well, that's the big question! It could be that the ID value you are passing is not what you thought, or you may be accessing the wrong DB, or the new values you are setting them to are the same as the old ones. We can't tell.

So, its going to be up to you.
Fortunately, you have a tool available to you which will help you find out what is going on: the debugger. How you use it depends on your compiler system, but a quick Google for the name of your IDE and "debugger" should give you the info you need.

Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Look at your id variable and check exactly what it contains - is it the ID you expect? If it isn't, why not?
If it is, use SSMS to look at the DB content and examine that row. Does it exist? What are its current values? Are they different to the values you are passing?
Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.
I'd also want to look at the return value from the SQL operation:

C#

int rowsAffected = sql.ExecuteNonQuery();

Sorry, but we can't do that for you - time for you to learn a new (and very, very useful) skill: debugging!

Hasan Syed (Zubeshi) · Answer 2 · 2018-02-02T00:53:00

Solution 2

check query string in "cmd" and copy query sting from your code and past in query analyzer then check your query.

Posted 2-Feb-18 0:53am

Hasan Syed (Zubeshi)

Comments

Mukthahar Shaik 2-Feb-18 10:54am

thank you for your replay. Query analyzer is tool?
presently i am using Visual Studio 2010. is VS 2010