Insert into with max +1 column value C#

Question

2.00/5 (1 vote)

See more:

Insert into sql with declared value max number value in column

What I have tried:

In update string working fine

string saveStaff = "declare @maxNo integer = 0 select @maxNo = isnull(max(redni_broj), 0) from dbo.drzave INSERT into dbo.drzave (redni_broj, Ime, Valuta, Poziv_na_broj, A2, A3, Num) VALUES ('@maxNo+1',@Ime,@Valuta,@Poziv_na_broj,@A2,@A3,@Num)";

Posted 2-Apr-18 7:24am

Goran Bibic

Updated 2-Apr-18 9:05am

Add a Solution

Comments

Goran Bibic 2-Apr-18 15:05pm

string saveStaff = "declare @maxNo integer = 0 select @maxNo = isnull(max(redni_broj), 0) from[dbo].[drzave] ; Set @maxNo=@maxNo+1; INSERT into [dbo].[drzave] (redni_broj) VALUES (@maxNo)";

2 solutions

Solution 2

Instead of trying to figure out what is the maximum value in a column I would suggest using an autonumbered field, for example IDENTITY (Property) (Transact-SQL) | Microsoft Docs[^]

Using such field the database automatically assigns new value without any additional client side logic. Just remember to define the column as primary key to enforce uniqueness.

Posted 2-Apr-18 7:38am

Wendelius

Updated 2-Apr-18 8:30am

v2

Comments

[no name] 2-Apr-18 13:39pm

I prefer sequences. Some more work, but much more freedom :-)

Wendelius 2-Apr-18 13:44pm

Yep, I know. I personally prefer GUID's because of various reasons, replication for example, but in this case I think identity is a good starting point.

Goran Bibic 2-Apr-18 13:47pm

Solution for me?

Maciej Los 2-Apr-18 13:50pm

This is solution for you, Goran!

Wendelius 2-Apr-18 14:03pm

If you don't use replication and do not have any other special requirements, IDENTITY is a very easy solution.

Maciej Los 2-Apr-18 13:49pm

5ed!

Wendelius 2-Apr-18 14:03pm

Thank you Maciej!

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Goran Bibic · Accepted Answer · 2018-04-02T09:07:00

Solution 3

string saveStaff = "declare @maxNo integer = 0 select @maxNo = isnull(max(redni_broj), 0) from[dbo].[drzave] ; Set @maxNo=@maxNo+1; INSERT into [dbo].[drzave] (redni_broj) VALUES (@maxNo)";

Posted 2-Apr-18 9:07am

Goran Bibic