Binary to hexadecimel conversion

Question

1.00/5 (1 vote)

See more:

I have following code:: I am getting the Argument Out of Range exception for the array and format exception that I already handled::How the code can be improved to eliminate these exceptions?

My input string is 128 bit binary string which I need to convert into 16 byte Hexadecimal value.

C#

var numOfBytes = (int)Math.Ceiling(line.Length / 8m);
                    var linebytes = new byte[numOfBytes];
                    var lenth = 8;

                    for (int j = 1; j <= numOfBytes; j++)
                    {
                        var startIndex = line.Length - 8 * j;
                        if (!int.TryParse(line, out lenth))
                        {
                            Console.WriteLine("{0} is non parsable character at the end of the string", line);
                        }
                        if (startIndex < 0)
                        {
                            lenth = 8 + startIndex;
                            startIndex = 0;
                        }
                        

                        string sub = line.Substring(startIndex, lenth);
                        linebytes[numOfBytes - j] = Convert.ToByte(sub, 2);

What I have tried:

The code I have tried is in the description.

Posted 25-Apr-18 4:23am

Prat142

Updated 25-Apr-18 5:39am

CHill60

v2

Add a Solution

Comments

Patrice T 25-Apr-18 16:39pm

Can you show sample input and output ?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

User 7429338 · Answer 1 · 2018-04-25T04:44:00

Solution 1

What is line.Length? Is it a multiple of 8?

numOfBytes is rounded up up from line.Length/8, which means numOfBytes * 8 may be larger than line.Length.
At the end of your loop, startIndex = line.Length - 8 * numOfBytes, which may be less than 0.
line.SubString(startIndex, length) will throw an ArgumentOutOfRange exception here.

Posted 25-Apr-18 4:44am

User 7429338

Comments

Prat142 25-Apr-18 10:48am

Yes line.length = 128 ..it will be always in multiple of 8

Richard MacCutchan · Answer 2 · 2018-04-25T05:41:00

Solution 2

To convert any array of bytes a hex string you just need:

C#

StringBuilder hexString = new StringBuilder();
for (int i = 0; i < byteArray.Length; ++i)
{
    hexString.Append(string.Format("{0:X2}", byteArray[i]));
}

Posted 25-Apr-18 5:41am

Richard MacCutchan