ID selector only passes onto pop-up page on 2nd button click

Question

0.00/5 (No votes)

See more:

I have a form that onclick passes the result (waybillno) over to the popup page as a URL with the id selectors. It only passes the result on the 2nd click and sends an empty selector result with the URL on the first click, which tells me the form is being passed before the variable is set. I have tried moving the code up to force the variable to be "created earlier" but is has not helped. Any help appreciated.
Here is the code:-

<!DOCTYPE html>
<html lang="en">

<head>

</head>
<div class="container">

    <div class="row margin-10">
        <div class="col-md-4">
            <h4 class="orange-grad"><span class="white">WAYBILL UPDATES</span></h4>
            <form class="form-horizontal" role="form" action="popuptest.php" method="get">
                <input type="text" name="waybillno" class="search-query form-control col-md-6" placeholder="Waybill #">
                <button onclick="myFunction()">Go Now</button>

            </form>
        </div>
    </div>
</div>
<?php $id=$_GET['waybillno'];
echo $id;?>

    <script>
        function myFunction() {

            var myWindow = window.open("popuptest1.php?id=<?php echo $id=$_GET['waybillno'];?>", " ", "width = 1200, height = 400, top = 100, left = 300 ");
        }
    </script>

</html>

What I have tried:

Moving the myFunction script around to see if the order of code makes a difference.
I have spent two full days on thi, researching but with no luck.

Posted 23-May-18 2:31am

Member 13840807

Updated 23-May-18 4:45am

Add a Solution

2 solutions

Solution 1

It would seem that the value, on the first click, is not yet there.
You load it via $_GET, but it has not yet been loaded the first click. That click, however, renders the page and now loads the value.

To be sure, you might wish to check the URL, which, as $_GET type, will show you the current value for 'waybillno'. Your function, which is called on button click, has the most recent value from .php, but that hasn't been set until after your first click.

(pass the value to your function with the button click, via javaScript, from your page body, instead of using .php at that point).

Posted 23-May-18 4:35am

W∴ Balboos, GHB

Updated 23-May-18 4:38am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 13840807 · Accepted Answer · 2018-05-23T04:46:00

Solution 2

Correct, but I am looking for a way for the value to be set in the script after the first click. Is this possible at all?
I have added the $Get as part of my Javascript function, but it still only works after the 2nd click.

Posted 23-May-18 4:46am

Member 13840807

Updated 23-May-18 4:47am

v2