Error wit update use inner join

Question

1.00/5 (1 vote)

See more:

Hello guys, I have problem with two querys Update and Insert using Inner Join.

I have three tables relation ship.

My application is C# Windows Forms connected with Access Database.

The follow fields are type Int:

Atados

Reorden

Pc_Atado

Vol


This is my query:

private void btnAct_Click(object sender, EventArgs e)
        {
            String sql = "UPDATE tLEADS INNER JOIN (tBUNDLES INNER JOIN tLOCALES ON tBUNDLES.IdBUNDLES = tLOCALES.IdLOCALES) ON tLEADS.IdLEADS = tBUNDLES.IdBUNDLES SET tLEADS Mnbr='" + txtMaq.Text + "', Rack=" + txtRack.Text + ", Nivel='" + txtNiv.Text + "', Localizacion='" + txtLoc.Text + "', Atados=" + txtAta.Text + ", Reorden=" + txtReor.Text + ", Pcs_Atado=" + txtPcs.Text + ", Vol=" + txtVol.Text + ", WHERE IdLEADS = '" + txtBusLead.Text + "'";
            try
            {
                con.Open();
                adapter = new OleDbDataAdapter(cmd);
                if (MessageBox.Show("Esta seguro que quiere actualizar el registro ??", "ALERTA: Actualizara un registro", MessageBoxButtons.OKCancel, MessageBoxIcon.Warning) == DialogResult.OK)
                {
                    cmd.ExecuteNonQuery();
                    MessageBox.Show("Registro actualizado correctamente...!", "Registro Actualizado", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
                }
                con.Close();
                CargaDg();
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.Message);
                con.Close();
            }
        }
    }
Let me know you comments please.

Dan

What I have tried:

private void btnAct_Click(object sender, EventArgs e)
        {
            String sql = "UPDATE tLEADS INNER JOIN (tBUNDLES INNER JOIN tLOCALES ON tBUNDLES.IdBUNDLES = tLOCALES.IdLOCALES) ON tLEADS.IdLEADS = tBUNDLES.IdBUNDLES SET tLEADS Mnbr='" + txtMaq.Text + "', Rack=" + txtRack.Text + ", Nivel='" + txtNiv.Text + "', Localizacion='" + txtLoc.Text + "', Atados=" + txtAta.Text + ", Reorden=" + txtReor.Text + ", Pcs_Atado=" + txtPcs.Text + ", Vol=" + txtVol.Text + ", WHERE IdLEADS = '" + txtBusLead.Text + "'";
            try
            {
                con.Open();
                adapter = new OleDbDataAdapter(cmd);
                if (MessageBox.Show("Esta seguro que quiere actualizar el registro ??", "ALERTA: Actualizara un registro", MessageBoxButtons.OKCancel, MessageBoxIcon.Warning) == DialogResult.OK)
                {
                    cmd.ExecuteNonQuery();
                    MessageBox.Show("Registro actualizado correctamente...!", "Registro Actualizado", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
                }
                con.Close();
                CargaDg();
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.Message);
                con.Close();
            }
        }
    }

Posted 28-Aug-18 20:05pm

Dani Solis

Updated 28-Aug-18 20:22pm

Add a Solution

Comments

Richard Deeming 30-Aug-18 11:46am

Post the full details of the exception you're getting.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-08-28T20:23:00

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

And when you have finished updating your entire app - because if you miss just one it'll be a problem - you may well find your other problem has gone at the same time.