Java - array not reading data from a text file

Question

1.00/5 (1 vote)

See more:

I have a text file with 10 integers, 1 2 3 4 5 6 7 8 9 10. They print out in order however I am trying to find the smallest, largest and average out of the integers in the text file.

What I have tried:

Java

import java.io.File;
import java.io.FileNotFoundException;
import java.util.Scanner;

public class Exercise2txt {

	public static void main(String[] args) throws Exception {

		int[] numbers = new int[10];

		int largest = Integer.MIN_VALUE;
		int smallest = Integer.MAX_VALUE;
		double total = 0;
		double avg;
		int i = 0;

		
			Scanner inFile = new Scanner(new File("numbers.txt"));

			for (int y = 0; y < 10; y++) 
				System.out.println(inFile.nextInt());
			
			if (numbers[i] > largest) {
				largest = numbers[i];
			}

			if (numbers[i] < smallest) {
				smallest = numbers[i];
			}

			for (int x = 1; x < numbers.length; x++) {
				total += numbers[x];
			}

			avg = total / numbers.length;
		

		System.out.println("Largest number = " + largest);
		System.out.println("Smallest number = " + smallest);
		System.out.println("The average of all numbers = " + avg);

	}
}

This is the code i have at the moment

Posted 11-Oct-18 16:50pm

Member 14016813

Updated 11-Oct-18 22:00pm

Patrice T

v2

Add a Solution

2 solutions

Solution 2

Your code is almost complete, you've just to properly read the file. Try

Java

import java.io.File;
import java.io.FileNotFoundException;
import java.util.Scanner;

public class Exercise2txt {

  public static void main(String[] args) throws Exception {

    int[] numbers = new int[10];

    int largest = Integer.MIN_VALUE;
    int smallest = Integer.MAX_VALUE;
    int count = 0;
    double sum = 0.0;
    double avg;
    Scanner inFile = new Scanner(new File("numbers.txt"));
    while ( inFile.hasNext())
    {
      int n = inFile.nextInt();
      if ( largest < n)
        largest = n; 
      if (smallest > n)
        smallest = n;
      sum += n;
      ++count;
    }
    avg = sum / count;

    System.out.println("Largest number = " + largest);
    System.out.println("Smallest number = " + smallest); 
    System.out.println("The average of all numbers = " + avg);
  }
}

Posted 11-Oct-18 22:00pm

CPallini

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2018-10-11T17:17:00

Quote:
They print out in order

This is exactly what you do in your code.

Java

System.out.println(inFile.nextInt());

This line is reading from file and printing, but where is the magic that save the integer for future use ?

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.
Debugger - Wikipedia, the free encyclopedia[^]
http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jdb.html[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Java - array not reading data from a text file

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us