Error when executing multiple if conditions

Question

0.00/5 (No votes)

See more:

Hi! This is the usersignup.php codes. So i want to confirm if both password match or not as well as i wanted to make my username a unique data. So far the codes for username works well but codes on checking if both passwords match, does not work where the php page appears blank

so the actual outcome should be an alert saying that "both passwords don't match"

Under the if statement on checking the password i have tried on other codes like
'echo "Passwords don't match!";', it works perfectly

so i guess if there is error on the codes for the alert function or on the if statement.

What I have tried:

<?php

include("conn.php");

//retreive data from register.html
$username = $_POST['username'];
$password = $_POST['password'];
$confirmpassword = $_POST['password2'];
$email = $_POST['email_address'];  
$query = "SELECT * FROM users WHERE username='$username'";
$result = mysqli_query($con, $query) or die(mysqli_error($con));
$count = mysqli_num_rows($result);


if ($password !== $confirmpassword) {
	echo "<script>window.alert('Passwords don't match!'); ";
	die("window.history.go(-1);</script>");

}else if ($count>0) {
	echo "<script>alert('Sorry! Username already exist!'); ";
	die("window.history.go(-1);</script>");
}


		$sql = "Insert into users (firstname,lastname,username,email,dob,password) 
		VALUES ('$_POST[first_name]','$_POST[last_name]','$username','$email','$_POST[dob]','".md5($password)."');";

		mysqli_query($con, $sql);

		//echo $sql
		if(mysqli_affected_rows($con)<=0)
		{
			echo "<script>alert('Unable to register ! \\nPlease Try Again!');";
			die("window.history.go(-1);</script>");
		}

			echo "<script>alert('Register Successfully!Please login now!');";
			echo "window.location.href='Login.html';</script>";			
?>

Posted 9-Nov-18 8:15am

Member 13864666

Updated 9-Nov-18 8:41am

Add a Solution

Comments

Richard Deeming 9-Nov-18 15:24pm

Don't use MD5 for passwords - it's extremely insecure. Instead, use PHP's built-in methods to store and verify your passwords:

PHP: password_hash[^]
PHP: password_verify[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2018-11-09T08:41:00

Quote:
so i guess if there is error on the codes for the alert function or on the if statement.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.
Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
phpdbg | php debugger[^]
Debugging techniques for PHP programmers[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

PHP

$query = "SELECT * FROM users WHERE username='$username'";

PHP

$sql = "Insert into users (firstname,lastname,username,email,dob,password) 
		VALUES ('$_POST[first_name]','$_POST[last_name]','$username','$email','$_POST[dob]','".md5($password)."');";

Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]