Check a data exist or not in file by checking 2 by 2 line using vbscript

Question

1.00/5 (2 votes)

See more:

I have a file like this : 7G8h6Tghstwt6Y.y8 . Then, I have a string data like this : "2w" & "fr" & "7G" I am going to check whether my string data exist in the file or not.

What I have tried:

<pre lang="vb"><pre>

filepath = "C:\Users\Desktop\TS.txt"
substrToFind = "2w" & "fr" & "6J"

For i = 1 To Len(tmpStr) Step 2
    If InStr(tmpStr, substrToFind) <= 0 Then
        WScript.Echo "0:"
    Else
        WScript.Echo "1"
    End If

Next

Posted 19-Feb-19 20:35pm

Member 14156312

Updated 21-Feb-19 16:54pm

Add a Solution

Comments

OriginalGriff 20-Feb-19 2:51am

This is not a good question - we cannot work out from that little what you are trying to do.
Remember that we can't see your screen, access your HDD, or read your mind - we only get exactly what you type to work with. So tell us what happens that you didn't expect, or didn't happen that you did. Tell us what you did to make it happen, what you tried to find out why, where you are stuck, when help you need.
At the moment, all we have is a vague description and a tiny bit of code that does nothing too obvious.

Use the "Improve question" widget to edit your question and provide better information.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Answer 1 · 2019-02-19T22:38:00

Solution 1

Well it's always a good idea to actually open the file first!

Dim objFile, tmpStr, objFSO
Const ForReading = 1
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile= objFSO.OpenTextFile("C:\Users\Desktop\TS.txt", ForReading)

Then you can read it line by line if your really want to...

Do While Not objFile.AtEndOfStream
   tmpStr = objFile.readline
   ' Do your checks in here
Loop
objFile.Close

Or you could just read in the entire file

tmpStr = objFile.ReadAll

Your next problem is the stuff you are trying to find substrToFind = "2w" & "fr" & "6J" will actually result in you trying to find the string

"2wfr6J"

- I don't think that is really what you mean. You should search for 2w, fr and 6J separately.

Dim b1, b2, b3
b1 = False : b2 = False : b3 = False
Const vbTextCompare = 1
If Instr(1, tmpStr, "2w", vbTextCompare) > 0 Then
    b1 = True
End If
If Instr(1, tmpStr, "fr", vbTextCompare) > 0 Then
    b2 = True
End If
If Instr(1, tmpStr, "6J", vbTextCompare) > 0 Then
    b3 = True
End If
If b1 And b2 And b3 Then
    WScript.Echo "Found"
End If

Also note that I've made the search do a text search - the default for Instr is binary.

Finally, here is some reference material - always a good place to start
VBScript - OpenTextFile Method[^]
VBScript - ReadAll Method[^]
VBScript - InStr Function[^]

Posted 19-Feb-19 22:38pm

CHill60

Updated 20-Feb-19 23:06pm

v2

Comments

Member 14156312 21-Feb-19 2:04am

Thanks, great solution. But I still get error name redifined vbTextCompare

CHill60 21-Feb-19 2:12am

Then remove the line Const vbTextCompare = 1You must already have it defined somewhere (or it's predefined for you... it's been a long time since I used vbScript)

Member 14156312 21-Feb-19 3:14am

But It not work. with this code below

Member 14156312 21-Feb-19 2:24am

But It look not work
Dim b1, b2, b3
Dim objFile, tmpStr, objFSO
Const ForReading = 1
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile= objFSO.OpenTextFile("C:\Users\TT.txt", ForReading)

tmpStr = objFile.ReadAll
WScript.Echo tmpStr

b1 = False : b2 = False : b3 = False
If Instr(1, tmpStr, "2w") > 0 Then
b1 = True
End If
If Instr(1, tmpStr, "fr") > 0 Then
b2 = True
End If
If Instr(1, tmpStr, "6J") > 0 Then
b1 = True
End If
If b1 And b2 And b3 Then

WScript.Echo "Found"
End If

CHill60 21-Feb-19 5:07am

I've updated my solution - I hadn't set a value for b3 (didn't edit it properly after copy+paste). Where it said

If Instr(1, tmpStr, "6J") > 0 Then
b1 = True
End If

that should have read

If Instr(1, tmpStr, "6J") > 0 Then
b3 = True
End If

Member 14156312 21-Feb-19 21:15pm

But It still not work, It cannot check the string found or not in the text file.

Dim b1, b2, b3
Dim objFile, tmpStr, objFSO
Const ForReading = 1
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile= objFSO.OpenTextFile("C:\Users\TST.txt", ForReading)

tmpStr = objFile.ReadAll
WScript.Echo tmpStr

b1 = False : b2 = False : b3 = False
If Instr(1, tmpStr, "2w") > 0 Then
b1 = True
End If

If Instr(1, tmpStr, "fr") > 0 Then
b2 = True
End If

If Instr(1, tmpStr, "6J") > 0 Then
b3 = True
End If

If b1 And b2 And b3 Then
WScript.Echo "Found"

End If

CHill60 22-Feb-19 1:36am

"The string"...all 3 strings have to be present for this to say found.
You have changed this to do a binary comparison instead of text..try putting that back

Member 14156312 22-Feb-19 1:56am

What do you mean? I dont change anything in thats code, I just remove vbTextcompare

CHill60 22-Feb-19 2:31am

Removing vbTextCompare allows InStr to default to binary comparison.
You also still have the bug from my original post, which I fixed for you. See the comment above

Member 14156312 22-Feb-19 2:51am

you mean this code?
It does not work too.

Dim objFile, tmpStr, objFSO
Const ForReading = 1
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile= objFSO.OpenTextFile("C:\Users\TST.txt", ForReading)

tmpStr = objFile.ReadAll

Dim b1, b2, b3
b1 = False : b2 = False : b3 = False

If Instr(1, tmpStr, "2w", vbTextCompare) > 0 Then
b1 = True
End If
If Instr(1, tmpStr, "fr", vbTextCompare) > 0 Then
b2 = True
End If
If Instr(1, tmpStr, "6J", vbTextCompare) > 0 Then
b3 = True
End If
If b1 And b2 And b3 Then
WScript.Echo "Found"
End If

CHill60 22-Feb-19 3:27am

"It does not work" does not help. You are checking a different file than in your solution. You are also checking for different values - does the file actually contain the text being checked for?

Member 14156312 22-Feb-19 4:22am

Ya, the string ("2w", "fr", "6") contain of the TST.txt file.

CHill60 22-Feb-19 5:10am

"6" or "6J"? Be precise. In your solution below that you claim works does it echo all three of the found messages or just two of them? Because your code is not that different from mine - you just echo that you've found them.

Member 14156312 24-Feb-19 20:42pm

"6J" . three of the echo found messages works.

CHill60 25-Feb-19 4:28am

In which case my code should work as well. However, to answer the question that you posted as a solution, you need to understand how to use "else" VBScript Tutorial - If Statement[^]

Member 14156312 · Answer 2 · 2019-02-21T16:55:00

This is working. But I can not figure out to print the result if the string is not found. Any Idea? Help me please

Dim fb1, fb2, fb3
Dim objFile, FBString, objFSO
Const ForReading = 1
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile= objFSO.OpenTextFile("C:\Users\fitri\Desktop\Project 2\ScanFB\FS_Data\FS_TST.txt", ForReading)

FBString = objFile.ReadAll
WScript.Echo "Feature_Byte : "  & FBString

fb1 = False : fb2 = False : fb3 = False
If Instr(1, FBString, "6J") > 0 Then
	fb1 = True
	WScript.Echo "Found 6J"
End If

If Instr(1, FBString, "fr") > 0 Then
	fb3 = True
	WScript.Echo "Found fr"
End If

If Instr(1, FBString, "jC") > 0 Then
	fb3 = True
	WScript.Echo "Found jC"
End If