C# Problem with location panel code

Question

2.50/5 (2 votes)

See more:

This is my code

C#

if (tineline.Location == new Point(newlabel.Location.X, newlabel.Location.Y))
     {
         MessageBox.Show("HI");
     }

and my error is that the message box doesn't pop-up

I already have

Label newlabel = new Label();Label newlabel2 = new Label();

so when I put a label down like doesn't show a messagebox. this is my timer1 code

C#

int linenumber = 0;
        private void timer1_Tick(object sender, EventArgs e)
{
    linenumber++;
            if (tineline.Location.X >= 369)
            {
                tineline.Location = new Point(133, 16);
                pb1.Location = new Point(pb1.Location.X, pb1.Location.Y + 28);
                label5.Text = "" + linenumber;
            }

            if (tineline.Location == new Point(newlabel.Location.X, newlabel.Location.Y))
            {
                MessageBox.Show("HI");
            }


            if (trackBar1.Value == 1)
            {
                tineline.Location = new Point(tineline.Location.X + 1, tineline.Location.Y);
            }
            if (trackBar1.Value == 2)
            {
                tineline.Location = new Point(tineline.Location.X + 5, tineline.Location.Y);
            }
            if (trackBar1.Value == 3)
            {
                tineline.Location = new Point(tineline.Location.X + 10, tineline.Location.Y);
            }
        }

(labels are inside a panel)
Can some one help me, im trying to make it so when one of the locations X or Y is the same as the label it will show the message, can anyone plz help?

Posted 1-Apr-11 22:59pm

C.CoderCreator

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2011-04-02T00:24:00

As griff said, that won't work because your comparing the object's pointers - not the actual contents.

You could write an extension method to abstract away the comparison from the programmer:

C#

public static class ExtensionMethods
{
    public static bool MatchesLocation(this Point thisPt, Point thatPt)
    {
        return (thisPt.X == thatPt.X && thisPt.Y == thatPt.Y);
    }
}

and then you could call it like this:

C#

if (tineline.Location.MatchesLocation(newlabel.Location))
{
    MessageBox.Show("HI");
}

OriginalGriff · Answer 2 · 2011-04-01T23:14:00

That won't work. They two points are not the same, and never will be. They may contain the same information, but that doesn't mean they are the same point.

Instead, try this:

if (tineline.Location.X == newlabel.Location.X && tineline.Location.Y == newlabel.Location.Y)
     {
         MessageBox.Show("HI");
     }

When you do an "==" check, it checks the references, not the contents, except when such behaviour is specifically overridden, as it is for strings. There are exceptions to this for simple types, but most complex types work this way.

C# Problem with location panel code

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0