Best Practice to create sqlParameters

Question

0.00/5 (No votes)

See more:

I want to insert values to table using Insert into statement.For that I used it like this.

C#

SqlCommand sqlCommand = new SqlCommand("Insert into item(itemcode,name) values (@itemcode,@itemName)");

Then I added parameters like this.
SqlParameter[] parameterList = new SqlParameter[2];

SqlParameter paraItemcode = new SqlParameter("@ItemCode", SqlDbType.Char);
paraItemcode.Value = anyValue;
parameterList[0] = paraItemcode;

SqlParameter paraName = new SqlParameter("@itemName", SqlDbType.VarChar);
paraName.Value = anyName;
parameterList[1] = paraName;

sqlCommand.Parameters.AddRange(parameterList);

Rather adding parameters like this, I can add parameters like this also
sqlCommand.Parameters.Add("@itemCode",SqlDbType.Char).Value=anyValue;
sqlCommand.Parameters.Add("@itemName",SqlDbType.VarChar).Value=anyName;

From those two, which approach is the best practice to use?

Posted 26-Apr-11 0:24am

Sanyon_d

Updated 26-Apr-11 0:38am

Sandeep Mewara

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CDP1802 · Answer 1 · 2011-04-26T00:31:00

Both approaches produce the same result, so from that point of view none of the two is better than the other. The second one eliminates having to fumble around with an array and is far less verbose. I think it makes the clearer and easier to understand and that's why I would go with that one.

Edit: The question might not be how to attach parameters to a command. It's far more important to isolate data access in a separate layer. There (and only there) should commands and parameters be constructed and used.

Rob Branaghan · Answer 2 · 2011-04-26T00:40:00

Solution 2

I use a method based on the second one! And I find this works best for me.

Because I wanted to create a method that can have many parameters I created it using a Generic List, so I can pass Parameter Name, Value and data type.

Posted 26-Apr-11 0:40am

Rob Branaghan

nit_singh · Answer 3 · 2011-04-26T00:48:00

All the approaches are same and will give you the same result. Using second approach you can save some line of code.
You can do the same thing with the below approach also

SqlParameter[] param = new SqlParameter[]
{
     new SqlParameter("@itemName", 10),
     new SqlParameter("@ItemCode", "Namw")
};

sqlCommand.Parameters.AddRange(parameterList);

Best Practice to create sqlParameters

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0