SQL Insert Statement

Question

1.33/5 (2 votes)

See more:

I am developing a three tier project and in dataservices when I am using the following code for instert statement I am getting this error "Invalid operation. The connection is closed."

public static void AddNewInventory(string STU_NAME, string GPA, string COURSE, string identification, string datetime)
        {
OracleDatabase db = (OracleDatabase)DatabaseFactory.CreateDatabase("WHTS");

string sql = "Insert into I_Student (STU_ID, STU_NAME, GPA, COURSE, IDENTIFICATION, DATETIME,) Values (I_STU_ID.NEXTVAL, '" + stu_name.Replace("'", "''") + "', '" + GPA.Replace("'", "''") + "', '" + COURSE.Replace("'", "''") + "', '" + identification.Replace("'", "''") +                    " '"  + "', DATETIME('" + DATETIME + " 00:00:00', 'MM/DD/YYYY HH24:MI:SS')";
            Console.WriteLine("Insert SQL = " + sql.ToString());

using (System.Data.Common.DbCommand cmd = db.GetSqlStringCommand(sql))            
     {

     cmd.ExecuteNonQuery();
     }

     }

Can anyone help me to slove this error

Thanks

Posted 23-Jul-11 7:28am

rbjanaki

Updated 23-Jul-11 7:36am

Uday P.Singh

v3

Add a Solution

7 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2011-07-23T07:34:00

Solution 1

Is the connection closed?
You can always add some defensive coding - check if the connection is closed before executing the query, and if it is, reopen it.

Posted 23-Jul-11 7:34am

Abhinav S

Comments

rbjanaki 23-Jul-11 13:39pm

But it is loading data into the forms when I am saving the data it is giving me this error. How can I reopen the connection?

[no name] 23-Jul-11 13:45pm

try db.Open();

rbjanaki 23-Jul-11 14:03pm

I tried that one and it is giving me this error Microsoft.Practices.EnterpriseLibrary.Data.Oracle.OracleDatabase' does not contain a definition for 'open' and no extension method 'open' accepting a first argument of type 'Microsoft.Practices.EnterpriseLibrary.Data.Oracle.OracleDatabase' could be found (are you missing a using directive or an assembly reference?

rbjanaki 23-Jul-11 13:54pm

I tried that one and it is giving me this error Microsoft.Practices.EnterpriseLibrary.Data.Oracle.OracleDatabase' does not contain a definition for 'open' and no extension method 'open' accepting a first argument of type 'Microsoft.Practices.EnterpriseLibrary.Data.Oracle.OracleDatabase' could be found (are you missing a using directive or an assembly reference?

[no name] 23-Jul-11 15:11pm

check this
http://msdn.microsoft.com/en-us/library/microsoft.practices.enterpriselibrary.data.database.openconnection%28v=pandp.31%29.aspx

Dave Kreskowiak · Answer 2 · 2011-07-23T15:32:00

Solution 2

I'm just going to comment on the quality of the code, not fix the problem.

Scrap that string concatenated attrocity and replace it with a parameterized SQL query. Then use Parameter objects to fill in the blanks. It'll make your code FAR easier to support and avoid hard-to-find coding errors. You won't have to worry about replacing all the single quotes that may be in the data if you do.

Posted 23-Jul-11 15:32pm

Dave Kreskowiak

Comments

Eslam Mostafa 24-Jul-11 2:05am

what about my solution

Dave Kreskowiak 24-Jul-11 9:18am

Who are you and WHAT solution?? You haven't posted anything in this entire discussion.

If you're just trying to get everyones attention to your solution to a different question, DON'T. You'll just end up pissing everyone off.

Mycroft Holmes · Answer 3 · 2011-07-24T13:04:00

Solution 3

I don't use EL but in SQL the command object (cmd) has a connection and you should be able to check it's state and open the connection.

if(cmd.Connection.ConnectionState == ConnectionState.Closed)

Posted 24-Jul-11 13:04pm

Mycroft Holmes

Bryian Tan · Answer 4 · 2011-07-24T16:14:00

Solution 4

hi,

I think the correct syntax should be something like below.

C#

using (DbCommand cmd= db.GetSqlStringCommand(sql))
{
    db.ExecuteNonQuery(cmd);
}

Here is an example on how to get DataSet, DataReader, single result

http://www.devx.com/dotnet/Article/30910/1954[^]

Posted 24-Jul-11 16:14pm

Bryian Tan

shefeekcm · Answer 5 · 2011-07-24T18:09:00

Solution 5

HI,
use try catch to handle this,

if the connection is open then leave it,otherwise open it,same apply in the other case also

Posted 24-Jul-11 18:09pm

shefeekcm

ohkuy · Answer 6 · 2011-07-24T18:26:00

MIDL

using (System.Data.Common.DbCommand cmd = db.GetSqlStringCommand(sql))
     {
        using(SqlConnection con=new SqlConnection(yourConnectionString)
        {
           //if you has Method or:
           //using(System.Data.Common.DbCommand cmd = db.GetSqlConnection(yourConnectionString))
           if(cmd.Connection.ConnectionState == ConnectionState.Closed)
           {
              con.Open();
           }
           md.ExecuteNonQuery();
        }
     }

rbjanaki · Answer 7 · 2011-07-26T05:39:00

C#

public static void AddNewInventory(string STU_NAME, string GPA, string COURSE, string identification, string datetime)
        {
OracleDatabase db = (OracleDatabase)DatabaseFactory.CreateDatabase("WHTS");

string sql = "Begin Insert into I_Student (STU_ID, STU_NAME, GPA, COURSE, IDENTIFICATION, DATETIME,) Values (I_STU_ID.NEXTVAL, '" + stu_name.Replace("'", "''") + "', '" + GPA.Replace("'", "''") + "', '" + COURSE.Replace("'", "''") + "', '" + identification.Replace("'", "''") +                    " '"  + "', DATETIME('" + DATETIME + " 00:00:00', 'MM/DD/YYYY HH24:MI:SS');End";
            Console.WriteLine("Insert SQL = " + sql.ToString());

using (System.Data.Common.DbCommand cmd = db.GetSqlStringCommand(sql))
     {

     db.ExecuteNonQuery(cmd);
     }

     }

Finally I got it worked I just added begin and end to my sql statement