Passing myControl.ClientID - to quote or not to quote

Question

0.00/5 (No votes)

See more:

So one thing I often do in the codebehind is setup the javascript events to avoid in-line code.

C#

myButton.Attributes.Add("onclick", string.Format("fnDoSomething(this, '{0}', '{1}');", myList.CliendId, myStatus.CliendId));

Very standard, nothing exciting. But one day I forgot the quotes:

C#

myButton.Attributes.Add("onclick", string.Format("fnDoSomething(this, {0}, {1});", myList.CliendId, myStatus.CliendId));

To my surprise in the script I had actually passed the myList and myStatus objects themselves.... not the IDs.

This seemed pretty cool, no need to do a document.getElementById. But I was worried this wouldn't work on all browsers or in all circumstances.

Can anyone say difinitively if this is bad practice?

Posted 8-Aug-11 0:28am

Chris_Green

Updated 8-Aug-11 0:29am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Toniyo Jackson · Answer 1 · 2011-08-08T00:37:00

Solution 1

Nothing is surprise here. If you use single quotes, Javascript accept that as a string. So, you have to use document.getElementById to get the actual id. Whereas, if you are not using single quotes, Javascript will directly take this as a object. So, you don't want to use document.getElementById again.

Posted 8-Aug-11 0:37am

Toniyo Jackson

Comments

Chris_Green 8-Aug-11 6:39am

That's not what I was asking.

This is the question: But I was worried this wouldn't work on all browsers or in all circumstances. Can anyone say difinitively if this is bad practice?