error-improve use of typedef obj

Question

1.00/5 (1 vote)

See more:

I have error improve use of typedef obj in this c++ program.
This is swapping a program.
Please help me?

And explain the error and how to clear this error.

C++

#include
#include

class swap
{
int a,b;
public:
void getdata(void);
void change(void);
void display(void);
};

void swap :: getdata(void)
{
cout<<" enter the a value: ";
cin>>a;
cout<<"enter the b value: ";
cin>>b;
}

void swap :: change(void)
{
a = a+b;
b = a-b;
a = a-b;
}

void swap :: display(void)
{
cout<<"a value: "<<"\n";
cout<<"b value: "<<"\n";
}

void main()
{
clrscr();
class obj;
obj.getdata();
obj.display();
getch();
}

Posted 27-Sep-11 8:48am

kschandru

Updated 27-Sep-11 9:14am

André Kraak

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

André Kraak · Answer 1 · 2011-09-27T09:21:00

Solution 1

You use of the class keyword is wrong when defining a swap class variable.
Instead of using

C++

void main()
{
	clrscr();
	class obj;
	obj.getdata();
	obj.display();
	getch();
}

use

C++

void main()
{
	clrscr();
	swap obj;
	obj.getdata();
	obj.display();
	getch();
}

You can read these short tutorials to increase your knowledge about classes and variables:
Classes (I)[^]
Variables. Data Types.[^]

Posted 27-Sep-11 9:21am

André Kraak

Comments

Sergey Alexandrovich Kryukov 27-Sep-11 16:32pm

A good catch, my 5. I credited your solution in mine. My point was different -- the swap algorithm itself. Please see my update under [EDIT].
--SA

André Kraak 27-Sep-11 16:39pm

Thanks.

kschandru 27-Sep-11 22:54pm

@André Kraak: Thank u... thank for find out my error..... :-)

Sergey Alexandrovich Kryukov · Answer 2 · 2011-09-27T09:26:00

Probably you got an assignment two swap to integers without using temporary (stack) variable, otherwise you would honestly use a temporarily variable with no need to goof around.

This is a classical exercise which is very simple, so everyone is supposed to find the solution without reading anything, but of course based on knowledge of simple bit arithmetic.

[EDIT]
You result is correct though, but not elegant. There is a simple and universal way to swap any two bit patterns not using arithmetic of numeric types and not using any temporary storage for a value.
Your problem is the syntax. Use the advice by André Kraak.
[END EDIT]

Sorry, I don't want to tell you the solution, otherwise it would be not useful to you but would be cheating against people who honestly solve their assignment by themselves.

—SA