How To Get A Count Of Files

Question

1.00/5 (2 votes)

See more:

This code runs and works well, but I don't really want it to give me a messagebox with names. I want to get a count instead of the number of files there are instead. How can I rework this so that I get a count? Thank you.

C++

int GetFileList(const wchar_t *searchkey, std::map<std::wstring,> &map)
{
    WIN32_FIND_DATA fd;
    HANDLE h = FindFirstFile(searchkey,&fd);
    if(h == INVALID_HANDLE_VALUE)
    {
        return 0; // no files found
    }
    while(1)
    {
        wchar_t buf[128];
        FILETIME ft = fd.ftLastWriteTime;
        SYSTEMTIME sysTime;
        FileTimeToSystemTime(&ft, &sysTime);
        wsprintf(buf, L"%d-%02d-%02d",sysTime.wYear, sysTime.wMonth, sysTime.wDay);
        map[fd.cFileName] = buf;
        if(FindNextFile(h, &fd) == FALSE)
            break;
    }
    return map.size();
}

void main()
{ 
    std::map<std::wstring,> map;
    int count = GetFileList(L"C:\\Users\\DS\\Downloads\\*.zip", map)
    && GetFileList(L"C:\\Users\\DS\\Downloads\\*.txt", map);
	for(std::map<std::wstring,>::const_iterator it = map.begin(); 
      it != map.end(); ++it)
    {
      MessageBoxW(NULL,it->first.c_str(),L"File Name",MB_OK);
	  MessageBoxW(NULL,it->second.c_str(),L"File Date",MB_OK);
    }
}

Posted 28-Sep-11 12:44pm

Member 7766180

Add a Solution

Comments

Sergey Alexandrovich Kryukov 28-Sep-11 19:11pm

Voted 1 and reported as abuse. We should not help people who do not go in software development but trying to use codes they cannot even read properly. It leads nowhere.
--SA

Chuck O'Toole 30-Sep-11 21:31pm

SA, Did you ever get any feedback on the abuse report? Just how do the "powers that be" followup on such reports? The volume of new questions posted about the same old 10 or 20 lines of code seems to support your report and I was wondering what happens next.

Member 7766180 30-Sep-11 22:44pm

Are you kidding me? I thought you were trying to help me? How is this abuse? I'm trying to learn and do something and you want to report me. Shame on you!!!!! I'm jumping through all of your hoops to learn, you said I was learning and then.....want to get rid of me? Post the code to my problem and I'm outta here!!!!!!!

Kode King 30-Sep-11 23:23pm

Chuck O'Toole....Your next! You are no better, Ive been watching you as well. Maybe if you would help with some actual code, people could learn. Instead you take people thru one rabbit hole to the next. Terrible!

Chuck O'Toole 1-Oct-11 10:00am

I don't know you, you don't know me. I assume you are familiar with the "Give a man a fish" vs. "Teach a man to fish" example. I spent a lot of time posing questions to lead that person to the logic of debugging on his own. If all I did was give him answers, he wouldn't learn anything. I consider that helping. If I just gave him the code, he'd be back asking for yet another piece of code. So, after 2 days of exchanges designed for him to discover the answer himself, what you call the rabbit hole, he finally claims to have understood. And then he goes and ask 3 more questions, pasting the same 20 lines of code over again, and asking questions that clearly demonstrate that he doesn't have the basest understanding of programming, despite his claims of knowing VB and has done programming in the past. Lots of people who've been around alot longer than you or he have suggested that he go and actual read a book on programming and do the exercises in the book rather that go off and grab some "IP Packet Sniffer" off the net and try to make it work. Same with this "delete files created within the last minute" project. There's a reason you don't just give matches to children, you teach them about fire first. If he chooses to continue to engage people until they give him the code, he can do that without me. I earnestly tried and have given up. PS, if you saw The Matrix, you'd know the rabbit hole is where the truth was. Not necessarily a bad destination.

Kode King 1-Oct-11 14:48pm

First Chuck, I dont want to know you. Second do not even try to get to know me. Yes I hsve heard of "give a man a fish", but instead of a fish you are suppose to give the man a pole. I hardly consider a few tepid responses by you a pole! Maybe, the code is being posted over and over. (Your words not mine) is that you have failed to provide a solution, and from what I can see, they are different questions about the code. The person is obviously making headway and progressing. Thats how things work. One step leads to another! I'm sure your parents hid the mayches from you a long time ago. Play nice. Remember, "the powers that be"said don't make anyone feel stupid, try to help! If you don't want to answer the person, ignore them like you said you would. Otherwise, If you keep this up. I'll report you for abuse. Then you won't have to ask what happens!

Kode King 30-Sep-11 23:20pm

SAK...I've been watching you. You are a very abusive person. It's so much easier to be kind and helpful and far more rewarding! To report a beginner for asking a question! Get real the only one abusive here is you!!!!!!

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-09-28T13:09:00

Solution 1

You already got count. Remove a call to a MessageBoxW and re-think your life. Seriously.

—SA

Posted 28-Sep-11 13:09pm

Sergey Alexandrovich Kryukov

Comments

Member 7766180 28-Sep-11 19:18pm

Thank you for your answer.

Sergey Alexandrovich Kryukov 28-Sep-11 19:19pm

You are very welcome, I only sorry you don't follow my advice...
--SA

Member 7766180 28-Sep-11 19:30pm

Just a quick one. I want to see the value of count, so I tried this and it didn't work.
if (count != 0)
{
printf ("%s \n", "Delete",count);

}
else
{
printf ("%s \n", "Nothing");

Thank you so much!

Chuck O'Toole 28-Sep-11 19:36pm

printf ("%s \n", "Delete",count);

Has a format for only 1 argument, a string (%s) yet you are trying to print two values, "Delete" and count. Where is the format specifier that would output count?

Member 7766180 28-Sep-11 19:46pm

I tried this and it returned 1. I want to get the total count, not the count of each line.
printf("\n Delete: %i", count); I'm getting several lines.....
Delete: 1
Delete: 1
Delete: 1

Chuck O'Toole 28-Sep-11 20:06pm

You have an interesting and subtle bug, your output is exactly as expected. It would be better for your learning to figure it out for yourself, given the output your observe. Here's a clue. What does 'count' really represent? What is in the 'map'? Why if count is '1', does the loop run 3 times? Answer all those and you'll have found the problem.

Member 7766180 28-Sep-11 20:28pm

count represents each instance of a file, so it returns a Delete: 1 for each instance. The name of the file and the date are in the file, it runs untill its gone thru each file in the directory. I guess I need to get the total number of counts that are run?

Chuck O'Toole 28-Sep-11 20:44pm

Close, let me rephrase. I know what you *think* the variable 'count' should contain, the question is, what does it really contain. Hint, the answer is '1' so how did it get that way? Second question, why *isn't* it '3'. Don't use your preconceived notions of what 'count' is, be the computer and find out why it's set to '1'

Chuck O'Toole 28-Sep-11 20:46pm

ok, I'm feeling extra instructive today. One more hint. Examine the following statement from your code:

int count = GetFileList(L"C:\\Users\\DS\\Downloads\\*.zip", map)
&& GetFileList(L"C:\\Users\\DS\\Downloads\\*.txt", map);

Two questions, 1) what do you think it does? 2) what does it *really* do?

Member 7766180 28-Sep-11 21:24pm

Get file list so its giving me a list! Im sorry im from the VBA world and still trying to rethink!

Chuck O'Toole 28-Sep-11 23:08pm

Last hint for the night, do you know the difference between "ADD" and "AND", really, I'm not bool-sh*tting you :)

Member 7766180 28-Sep-11 23:46pm

Its the && between the two statements?

Member 7766180 28-Sep-11 23:56pm

When I rem out the second line I get the exact count of the zip files in that directory, when I use + it gives not a good number. So the problem first off is how to marry the two together!

Chuck O'Toole 29-Sep-11 0:26am

Congratulations, yes, it is the && (boolean AND). You have a function that returns a number of elements in the map as an int. Your boolean statement is simply stating "if the first call to GetFileList() returns non-zero AND the second call to GetFileList() returns non-zero, the expression is true otherwise false. Then it sets the int 'count' to the result of the boolean expression, converting bool 't/f' to int '1/0'. So, as written, count can only be 0 or 1. So now you know why count was 1 yet the number of printouts was larger. You pass this part of the exercise

Chuck O'Toole 29-Sep-11 0:30am

Now to the 2nd part of your question. When you add the two results, you do not get a good number. So, the exercise is for you to answer these questions (you may use the debugger to help you answer, this is not a closed book exam). 1) what does the return value of the GetFileList() mean, what is the return value trying to tell you? 2) Since you pass in the same 'map' during the two calls, what is the effect on the 'map' during the second call? Answer both and you should see the logic problem with respect to 'count' and adding them with +.

Member 7766180 29-Sep-11 15:31pm

It's actually doubling! Darn so how in the world do I inject other file types! Thank you.

Chuck O'Toole 29-Sep-11 16:14pm

Take a breath and think instead of react. What makes you think it's doubling? Is it because you see 2x the number you expect? As an experiment, add some more files to one or other of your test folders and see what the answers result. "Doubling" may just be a coincidence, it may be returring the sum of two equal sized elements. Experiment and Learn.

PS, it's definitely NOT doubling but it is returning a value like I expect (I do not have your data / files / test folders so I can't give you the exact answer).

Member 7766180 29-Sep-11 21:59pm

Got It! This returns the correct number....
int count = GetFileList(L"C:\\Users\\DS\\Downloads\\*.pdf", map);
int count1 = GetFileList(L"C:\\Users\\DS\\Downloads\\*.txt", map);
int count2 = GetFileList(L"C:\\Users\\DS\\Downloads\\*.jpg", map);
printf("\n Delete: %i \n", count+count1+count2);
Thank you, Chuck for your help!!!!! I hope this is right!

Chuck O'Toole 29-Sep-11 22:05pm

Close enough for partial credit. Since you pass the same 'map' into each call, and given that the function adds entries to the 'map', count represents the number of PDF files, count1 represents the number of TXT AND PDF files, count2 represents the number of JPG AND TXT AND PDF files. GetFileList() returns the number of items in the 'map' and you are extending the 'map' with each call. Therefore, only 'count2' is needed, it represents the total size of the 'map'. Adding count+count1+count2 is still wrong as the total lenght. PS, you could just have used 'map.size()' if you wanted to know the number of items and avoided all these messages but then you wouldn't have learned anything :)

Member 7766180 29-Sep-11 22:48pm

Thank you Chuck, even partial credit means alot to me. See I'm learning!!! I will look into map size. Would it be easy to institute?

Member 7766180 29-Sep-11 22:51pm

So being this, can I remove count and count1 from in front of the GetFileList() and say just have a count in front of the last one?

Chuck O'Toole 29-Sep-11 22:06pm

Now just remember to put 'std::' in front of your 'wstring' uses, even in struct definitons.

Member 7766180 29-Sep-11 22:48pm

Thank you!

Chuck O'Toole 28-Sep-11 23:33pm

To clarify, forget the list for a moment. What does that statement do with respect to 'count'. Right now, 'count' is what's hanging you up so let's focus on just that.

Chuck O'Toole 28-Sep-11 19:38pm

PS, when you post questions like this, saying "it didn't work" doesn't help at all. At least say what output you saw. A better question would have been "...so I tried this and all it printed was 'Delete' and no value". That would have been a clue.

Member 7766180 28-Sep-11 19:46pm

Your right.

Chuck O'Toole 28-Sep-11 19:20pm

you really should read code you copy from web sites for comprehension and retention.