ASP.NET(Problem in insertion sql server database)

Question

0.00/5 (No votes)

See more:

Why this code is inserting one empty record on the top of the table..?

C#

protected void Button1_Click(object sender, EventArgs e)
   {
       try
       {
           string Register = "INSERT INTO Userregistrationtable(Emailid,Dname,Mobileno,passwd,Gender,City,Area,Postal,Adress,DOB,Uskill,dream,Bestfrnd,Favplace,Favdish,Hobbies,InterestIn) VALUES('" + TextBox1.Text + "','" + TextBox2.Text + "','" + TextBox3.Text + "','" + TextBox4.Text + "','" + RadioButtonList1.SelectedValue + "','" + TextBox6.Text + "','" + TextBox7.Text + "','" + TextBox8.Text + "','" + TextBox21.Text + "','" + TextBox20.Text + "','" + TextBox9.Text + "','" + TextBox10.Text + "','" + TextBox11.Text + "','" + TextBox17.Text + "','" + TextBox18.Text + "','" + TextBox19.Text + "','" + DropDownList4.SelectedValue + "')";
           dbClass.ConnectDataBaseToInsert(Register);

       }
       catch (Exception a)
       {

       }
       TextBox1.Text = "";
       TextBox2.Text = "";
       TextBox3.Text = "";
       TextBox4.Text = "";
       TextBox5.Text = "";
       TextBox6.Text = "";
       TextBox7.Text = "";
       TextBox8.Text = "";
       TextBox21.Text = "";
       TextBox20.Text = "";
       TextBox9.Text =  "";
       TextBox10.Text = "";
       TextBox11.Text = "";
       TextBox17.Text = "";
       TextBox18.Text = "";
       TextBox19.Text = "";
       DropDownList4.SelectedIndex=0;

   }

Posted 13-Dec-11 23:15pm

paney

Updated 13-Dec-11 23:16pm

NikulDarji

v2

Add a Solution

Comments

Shobana16 14-Dec-11 5:46am

Can you say what is the error did you get?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2011-12-13T23:27:00

There are so many things wrong with that, that I'm not surprised that it doesn't do what you want.
1) Don't use VS Default names - You may remember today that TextBox11 holds the Favourite place (or is that TextBox17?) but you won't next week. Use sensible names instead.
2) Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.
3) Don't trap an error and then ignore it - or strange things happen and you don't know why. Errors mean there is a problem: fix it, or report it. Never ignore it.
4) Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^]
5) Never assume that the user can type: check the email address could be valid, the mobile number is a number rather than a rude message. And so on.

Do the above, and then try again.