Access violation at address XXXXXX. Write of address XXXXXX :((

Question

2.00/5 (3 votes)

See more:

when i run my code
it says Access violation at address XXXXXX. Write of address XXXXXX
en line that its
d.plus(a,b)
whats wrong ~~plz~~ Pleases help:(

C++

#include <iostream>
#include <conio.h>


class Polynomial
{
public:
int array[100][100];
//==================================================
Polynomial::Polynomial() // constructor
{
for ( int i = 0; i < 100; i++ )
   for( int j=0;j<100;j++)
                           {
array[i][j] = 0;
}
}
//================================================
void set ( int a , int b,int c ) //set
{
array[a][b] = c;
}
//===================================================
Polynomial plus ( Polynomial x,Polynomial y )
{
Polynomial c1;

for ( int i=0; i<100; ++i ) {
    for(int j=0; j<100 ;++j){
 c1.array[i][j] = x.array[i][j] + y.array[i][j];
         }}

 return c1;
}
//===========================================

void print()
{
for (int i=99; i>= 0; i-- ) {
for(int j= 99; j>=0;--j){
if ( array[i][j] != 0 ) {
cout <<"+("<< array[i][j] <<")"<< "x^" << i <<"y^"<<j;
				}
			}
		}
	}
};

int main(){

Polynomial a, b, d,f;
a.set(2,2,3);
b.set(2,3,2);
d.plus(a,b);
getch();
}

Posted 23-Dec-11 9:14am

DominoBoy

Updated 23-Dec-11 9:17am

RaviRanjanKr

v2

Add a Solution

Comments

RaviRanjanKr 23-Dec-11 15:17pm

It should be better to avoid short texts words like Plz instead of using Please while questioning and Answering. :)

DominoBoy 23-Dec-11 15:18pm

:|

Chuck O'Toole 23-Dec-11 16:02pm

Dunno dude, it doesn't blow up for me. Using VS2008.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-12-23T10:25:00

I tested the code and did not get the exception.

You loose the result of calculation though; do something like that:

C#

f = d.plus(a,b);
_getch(); // not deprecated getch()

The code is pretty bad though; in particular, you should not hard-code this '100', especially if you use it in different places. How can you support it if you want to change this 100 to something else? The whole idea is wrong; you should pass the rank via constructor, for example. It's pointless to carry many unused elements. You really need to allocate the arrays dynamically. Also, what's "polynomial" in this class. A polynomial expressions can be operated in Computer Algebra Systems (CAS), for example, in symbolic calculations.

Please see this useful overview of returning the class instance: http://www.informit.com/articles/article.aspx?p=25033&seqNum=3[^].

—SA

Michael Haephrati · Accepted Answer · 2011-12-25T10:19:00

Solution 2

Use i++ instead of ++i and j++ instead of ++j.
When you run a loop as long as i or j are smaller than 100, but you promote i and j using ++i or ++j, the last round, i or j becomes 100 and you access a cell in the array that doesn't exists (since the range of cells is 0 to 99).
But if you use i++ and j++, then when they get to 100, the program exits the loop without them having the value of 100.

Posted 25-Dec-11 10:19am

Michael Haephrati

Comments

Chuck O'Toole 25-Dec-11 20:29pm

Nope, sorry. In the code above, all instances of unary ++ or -- are in single statements for loop control. i++ or ++i have absolutely no difference in how it affects i in those statements, same thing for j. Yes, the order of operations may be inportant in other type of uses for unary ++ or -- but not in this instance and it is not the source of whatever perceived problem this user has. Note that both SA and I have built the code the OP posted and do not have the problem.