Adding data to database in C# problem

Question

0.00/5 (No votes)

See more:

string connection = "Data Source=.\\SQLEXPRESS;AttachDbFilename=|DataDirectory|\\Database1.mdf;Integrated Security=True;User Instance=True";
        SqlConnection cn = new SqlConnection(connection);
        cn.Open();

        string sqlquery = "INSERT INTO [users] (member, pass) VALUES (@memb ,@pas)";

        SqlCommand cmd = new SqlCommand(sqlquery, cn);

        cmd.Parameters.AddWithValue("@memb", SqlDbType.VarChar).Value = textBox1.Text;
        cmd.Parameters.AddWithValue("@pas", SqlDbType.VarChar).Value = textBox2.Text;

        int i = (int)cmd.ExecuteNonQuery();

        if (i > 0)
        {
            this.Close();
            Form2 form2 = new Form2();
            form2.Show();
            MessageBox.Show("Data updated", "Adding data", MessageBoxButtons.OK, MessageBoxIcon.Information);

        }
        else
        {
            MessageBox.Show("Error", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
        }
        cn.Close();

Can someone explain it to me, why it doesn't add data to database ?

Posted 24-Jan-12 2:53am

Ryszard50

Updated 24-Jan-12 3:48am

fjdiewornncalwe

v2

Add a Solution

Comments

Abdul Quader Mamun 24-Jan-12 9:02am

Where is the explanation???

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bryian Tan · Answer 1 · 2012-01-24T06:52:00

Solution 3

hi,

This post described somewhat similar problem: http://stackoverflow.com/questions/3317868/insert-problem-in-c-using-sqlcommand[^]

I would also suggest to move cn.Close(); to below

C#

int i = (int)cmd.ExecuteNonQuery();

because the cn.Close() method never get call if i > 0

Posted 24-Jan-12 6:52am

Bryian Tan

Updated 24-Jan-12 7:36am

v2

Sourav Sarkar-SS · Answer 2 · 2012-01-24T11:07:00

Solution 5

your Database means Database1.mdf required some configurations.

1. The Database1.mdf should be placed within Bin\dubug folder of your application.

2. Select Database1.mdf, open properties windows by pressing F4. the "Copy to Output Directory " should be set as "Do not copy".
it may generate error so first time change it to "Copy if newer" then change it to "Do not copy".

There is no Problem with the code written by you.
Hope this will help you.
Happy Coding.

Posted 24-Jan-12 11:07am

Sourav Sarkar-SS

Comments

Ryszard50 24-Jan-12 17:52pm

Hi Sourav92, thanx for a hint but when I changed to "do not copy" I always get this message : An attempt to attach an auto-named database for file C:\Documents and Settings\.....\bin\Release\Database1.mdf failed. A database with the same name exists, or specified file cannot be opened, or it is located on UNC share. unless I change it to "copy if never" after that there is no error but it doesnt write data to database.

[no name] 25-Jan-12 10:46am

now see there will be a folder in your Bin\Debug
named as bin\debug. delete the folders first.

AmitKumar89 · Answer 3 · 2012-01-24T19:44:00

Solution 6

You are using local database. You just try with the new object of SqlParameter. Otherwise it is ok...

Posted 24-Jan-12 19:44pm

AmitKumar89

Comments

Ryszard50 25-Jan-12 4:28am

Can you give an example 'cos I can't see your point. Sorry but Im beginer in programming.

Syed Salman Raza Zaidi · Answer 4 · 2012-01-24T03:10:00

Solution 1

May be this is the reason insertion is failing,you are casting the result of ExcecuteNonQuery()

int i = (int)cmd.ExecuteNonQuery();

ExecuteNonQuery() returns integer so no need to cast it

Or the other reason may be your primary key is not autoincrement and should be given in insert statement

Posted 24-Jan-12 3:10am

Syed Salman Raza Zaidi

Comments

CodeHawkz 24-Jan-12 11:35am

Should not be the case :) Converting int to an int or converting any type to the same type should not fail in any case. I mean, there is NO logical explanation for that :)