This thread is solved!

Question

1.00/5 (1 vote)

See more:

.... And I don't see where I made mistake
This is what I have done:

Java

int count = 0;
int sum = 0;
int average = 0;
File file = new File("dvorak.txt");
Scanner inputFile = new Scanner(file);




if (!file.exists())
{
    System.out.println("No file");
    System.exit(0);
}
while(inputFile.hasNext())
{
    String text = inputFile.nextLine();
    int length = text.length();
    sum = sum + length;
    average = sum / length;



}
System.out.println(average);

Posted 23-Feb-12 14:40pm

Alexander Alekseyevich Fedoseev

Updated 23-Feb-12 15:49pm

v4

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2012-02-23T14:48:00

Solution 1

Please remove calculation of average out of the loop and calculate the average correctly. In the loop, collect number of lines (you don't count them at all) and after the loop is done, calculate average by dividing sum by number of lines (and not by length, which is the the length of a current line and should not be declared outside of the loop).

—SA

Posted 23-Feb-12 14:48pm

Sergey Alexandrovich Kryukov

Updated 23-Feb-12 14:52pm

v2

Comments

Manfred Rudolf Bihy 23-Feb-12 20:55pm

I see you answered before me! Correct as ever ;)
5!

Sergey Alexandrovich Kryukov 23-Feb-12 21:05pm

Before you? Only because it's short. Thank you, Manfred.
--SA

Alexander Alekseyevich Fedoseev 23-Feb-12 21:48pm

Thank you a lot!

Sergey Alexandrovich Kryukov 23-Feb-12 21:58pm

You are welcome.
Good luck,
--SA

Monjurul Habib 26-Feb-12 6:12am

5!

Sergey Alexandrovich Kryukov 26-Feb-12 12:39pm

Thank you, Monjurul.
--SA

Manfred Rudolf Bihy · Accepted Answer · 2012-02-23T14:50:00

Just a little change:

Java

int count = 0;
int average = 0;
File file = new File("dvorak.txt");
Scanner inputFile = new Scanner(file);


if (!file.exists())
{
    System.out.println("No file");
    System.exit(0);
}
int totalLength = 0;
int lineCount = 0;
while(inputFile.hasNext())
{
    String text = inputFile.nextLine();
    lineCount += 1;
    totalLength += text.length();
}
average = totalLength / lineCount;
System.out.println(average);

That should do the trick. You count all the line lengths in the file and then divide by the number of lines collected.

Regards,

Manfred