C# bonds contains on a label

Question

4.00/5 (1 vote)

See more:

this is mt code
beatdetector= picurebox

C#

foreach (Control pControl in panel1.Controls)
            {
              Label pLabel=pControl as Label;
              if (null != pLabel)
              {
if (BeatDetector.Bounds.Contains(pLabel))
                     {
                         msgbox.show("it touched!!!");
                     }

              }

             }

this is my 2 errors

Error	1	The best overloaded method match for 'System.Drawing.Rectangle.Contains(System.Drawing.Rectangle)' has some invalid arguments	Z:\ll Studio\ll Studio\Form1.cs	193	29	ll Studio

Error	2	Argument 1: cannot convert from 'System.Windows.Forms.Label' to 'System.Drawing.Rectangle'	Z:\ll Studio\ll Studio\Form1.cs	193	58	ll Studio

I know its not a rectangle or whatever, but I was wondering if this is possible?
when they touch the message box is ment to show up

Posted 7-Jun-12 0:40am

C.CoderCreator

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-06-07T04:42:00

Solution 1

Try:

C#

if (BeatDetector.Bounds.Contains(new Rectangle(pLabel.Location, pLabel.Size)))

However, you may want to check each of the four corner Points instead - Rectangle.Contains will only find objects which are entirely within the rectangle. If you check using the bounding rectangle for the label, then it will only detect when the label is entirely within the BeatDetector. You can use Rectangle.Contains(Point) or Rectangle.Contains(int, int)

Posted 7-Jun-12 4:42am

OriginalGriff

Comments

[no name] 7-Jun-12 21:04pm

I found the answer just after I posted it then I lost internet, but I did already find the answer and it was, if (BeatDetector.Bounds.Contains(pLabel.bounds){} ,but that did not work, it was not detected, I'm yet to try your method, and ty btw

OriginalGriff 8-Jun-12 3:28am

Welcome - and it didn't work because the Contains only reports true if the rectangle is fully contained.

[no name] 13-Jun-12 6:28am

I tried your code, it did not work, nothing happens

OriginalGriff 13-Jun-12 6:35am

What does or doesn't happen?

[no name] 13-Jun-12 6:43am

when the beatdetor touches the control nothing happens

OriginalGriff 13-Jun-12 6:55am

Lets see the detect code as you have it - just the bit that should work, I don't want the whole program! :laugh:

[no name] 13-Jun-12 7:09am

KK here is the whole code that I am using for this small section:

this is on beatdetor_move btw

// plays the sound and changes timer speed level
foreach (Control pControl in panel1.Controls)
{
Label pLabel=pControl as Label;
if (null != pLabel)
{
if (BeatDetector.Location.X == pLabel.Location.X)
{
if (pLabel.Location.Y == 0)
{
if (BeatDetector.Bounds.Contains(new Rectangle(pLabel.Location, pLabel.Size)))
{
MessageBox.Show("HI");
int.TryParse(pLabel.Text, out move);
}
}
else
{
if (Createlabel().Text == "KICK2")
{
SoundPlayer player = new SoundPlayer(Properties.Resources.KICK2);
player.Play();
}
}
}

}
}

OriginalGriff 13-Jun-12 7:22am

Ok.
As I said in my original answer "you may want to check each of the four corner Points instead - Rectangle.Contains will only
find objects which are entirely within the rectangle"
So if you check the label rectangle as a whole, all four corners must be contained within the BeatDetector in order for Contains to give a "hit". Check each corner instead - if any of them is within BeatDetector, then they have touched.
if ((BeatDetector.Bounds.Contains(pLabel.Location))
will detect the top left corner,
if (BeatDetector.Bounds.Contains(new Point(pLabel.Right, pLabel.Top)))
will detect the top right, and so on.
If you don't check all four corners then detection will depend on which way the label or BeatDetector is moving.

[no name] 14-Jun-12 4:38am

if (BeatDetector.Bounds.Contains(new Point(pLabel.Right, pLabel.Top)))
the code works but there one problem, the label doesn't get detected at high speeds :(, when the best detector is moving