Error on Quoted Data fetch from Database

Question

0.00/5 (No votes)

See more:

hii,

i have question that when i fetch data from database and if in the databse have some quoted dat e.g. D`DUN. this data is inserted in DB. when i execute select query like :

      Select city from glmast where glname='" + list_customer.Items[i].Value + "'

in list_cutomer  there is data in which some data are inserted like D`DUN like quotes. so it gives error like unclosed Quotation. 

so, how this will be solved because not all field contain Quotes.

Please Help Me..
Mitesh

Posted 29-Jun-12 23:06pm

Mits Machhi

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-06-29T23:19:00

Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

VB

Using con As New SqlConnection(strConnect)
	con.Open()
	Using cmd As New SqlCommand("SELECT city FROM glmast WHERE glname=@GLN", con)
                cmd.Parameters.AddWithValue("@GLN", list_customer.Items[i].Value)
		Using reader As SqlDataReader = cmd.ExecuteReader()
			While reader.Read()
				Console.WriteLine("City: {0}", reader("city"))
			End While
		End Using
	End Using
End Using

Doing this will also cure your problem...

"can you caonvert this vb code to c# code ? please"

C#

using (SqlConnection con = new SqlConnection(strConnect))
   {
   con.Open();
   using (SqlCommand cmd = new SqlCommand("SELECT city FROM glmast WHERE glname=@GLN", con))
      {
      cmd.Parameters.AddWithValue("@GLN",list_customer.Items[i].Value);
      using (SqlDataReader reader = cmd.ExecuteReader())
         {
         while (reader.Read())
            {
            Console.WriteLine("City: {0}", reader["city"]));
            }
         }
      }
   }

[edit]Fixed C# conversion - OriginalGriff[/edit]