Get the Product ID of the selected information from multiple combo boxes

Question

1.00/5 (1 vote)

See more:

example:

combobox0(product id) = ?
combobox1(product type) = Glass
combobox2(product subtype) = Commodity Glass
combobox3(product name)= Clear Float Glass
combobox4(product dimension) = 12 x 12 in

can you improve the code:

C#

string query = "select * from RawMat WHERE ProductName = '" +  cboproductname.SelectedItem.ToString() + "'";

Posted 1-Jul-12 1:35am

wolfsor

Updated 1-Jul-12 2:07am

v2

Add a Solution

Comments

Zoltán Zörgő 1-Jul-12 8:24am

It really depends on the data structure of your database - and your user requirements. If you are designing the database right now, you should consider tagging products with class=value pairs. This way filtering the product list is only a matter of matching tags. The only improvement at this point is using parameters instead of query string concatenation. You can also make cascading master-detail datasets and let the framework do the rest...

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-07-01T02:17:00

Solution 1

Yes.

1) Don't use "SELECT * FROM..." - specifiy your fields instead.
2) Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

Posted 1-Jul-12 2:17am

OriginalGriff