string reverse program using recursive function

Question

0.00/5 (No votes)

See more:

In this program i did't get output i did't find out my mistake any one point-out my mistake and give me a hint only and any other method 's there give the hint to me only...

C#

#include<stdio.h>
#include<conio.h>

void fun(char *s, int l1);
void main()
{
//void rev(char, int);
char str;
int l;
clrscr();

printf("Enter the string: ");
scanf("%s",&str);
printf("%s",str);
//s=&str;
l = strlen(str);
fun(&str,l);
getch();
}

void fun(char *s,int l1)
{
 char *temp;

 if(l1 == -1)
 exit(0);

 else
  {
    temp = s+(l1-1);
    printf("%c",*temp);
    l1-=1;
    fun(s,l1);
  }

}

Posted 21-Jul-12 0:32am

kschandru

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

enhzflep · Answer 1 · 2012-07-21T00:51:00

The thing that immediately leaps out at one is the fact that you're using memory that isn't yours!

That is to say, your variable 'str' is a char - it holds just 1 byte of memory, yet in the scanf statement you're reading an unknown number of chars into just one byte of memory you own and (unknown number of chars - 1) into memory that follows.

You should:

Allocate some memory, either statically or dynamically
use scanf_s[^], which allows you to specify the max # of chars copied

Either use:

C++

const int bufSize = 1024;
char str[bufSize];  // or some other arbitrary num long enough to hold string

or

C++

const int bufSize = 1024;
char *str;
str = (char*)calloc(bufSize, 1);   // see above note on length - alloc & clear mem

And then use:

C++

scanf_s("%s", str, bufSize-1);

I haven't looked at the rest of the program. This may or may not fix your problem. In any case, it's still an error that you should fix.