Problem while inserting date into a sql database

Question

0.00/5 (No votes)

See more:

Hi Friends,
Please anyone rectify the error, i m not able to insert the date from textbox to sql database

C#

protected void btnAdd_Click(object sender, EventArgs e)
       {
           if(cnn.State==ConnectionState.Closed)
           cnn.Open();
           string str=txtDate.Text ;
           DateTime dt;
           dt = DateTime.Parse(str);
           cmd= new SqlCommand("insert into tbl_holiday values('"+str.ToString()+"','"+txtHoliday.Text+"')",cnn);
           cmd.ExecuteNonQuery();
          


       }

Posted 9-Aug-12 1:33am

Rockstar_

Add a Solution

Comments

Prasad_Kulkarni 9-Aug-12 7:36am

..what error you're getting Vijay?

[no name] 9-Aug-12 7:45am

Probably because of str.ToString() when you wanted your dt. Why would you call ToString() on a string anyway?

3 solutions

Solution 2

pass your date time variable dt instead of str.

C#

protected void btnAdd_Click(object sender, EventArgs e)
       {
           if(cnn.State==ConnectionState.Closed)
           cnn.Open();
           string str=txtDate.Text ;
           DateTime dt;
           dt = DateTime.Parse(str);
           cmd= new SqlCommand("insert into tbl_holiday values('"+dt+"','"+txtHoliday.Text+"')",cnn);
           cmd.ExecuteNonQuery();



       }

Posted 9-Aug-12 2:07am

Santhosh Kumar Jayaraman

Comments

StianSandberg 9-Aug-12 8:10am

the dt will be converted to a string anyway. The SqlCommand CommandText is a string... AND it's vulnerable for sql injections!

Solution 3

As I can see your code, you are parsing the textbox value to datetime. But instead of parsed datetime,you are inserting string value of the textbox again. Try this:

C#

protected void btnAdd_Click(object sender, EventArgs e)
{
   if(cnn.State==ConnectionState.Closed)
   cnn.Open();
   string str=txtDate.Text ;
   DateTime dt;
   dt = DateTime.Parse(str);
   cmd= new SqlCommand("insert into tbl_holiday values('"+str.ToString()+"','"+dt+"')",cnn);
   cmd.ExecuteNonQuery();
}

--Amit

Posted 9-Aug-12 2:47am

_Amy

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

StianSandberg · Accepted Answer · 2012-08-09T02:05:00

First of all make sure your column has the right data type (DateTime)
Then keep dates as DateTime. No need to convert it to string before sending it to your database.

Then use a SqlParameter to send data. The code you are using now is vulnerable for sql injections!

C#

protected void btnAdd_Click(object sender, EventArgs e)
{
if(cnn.State==ConnectionState.Closed)
 cnn.Open();

 DateTime dt = DateTime.Parse(txtDate.Text);
 cmd = new SqlCommand("insert into tbl_holiday values(@date, @holyday)",cnn);
 cmd.Parameters.AddWithValue("@date", dt);
 cmd.Parameters.AddWithValue("@holiday", txtHoliday.Text);
 cmd.ExecuteNonQuery();
}

Also when you parse dates like you do, you should use TryParse to see if you actually can parse the input from the user.

C#

string d = txtDate.Text;
DateTime dt;
if(DateTime.TryParse(d, out dt))
{
    // Parse ok..
}
else{
    // Could not parse the date..
}