Click here to Skip to main content
15,886,518 members

Record not Updating UPDATE Command, MS Access

TinTin19 asked:

Open original thread
my INSERT and DELETE command is working but UPDATE command is not. whats wrong.. :(
VB
Private Sub Button1_Click(sender As System.Object, e As System.EventArgs) Handles Button1.Click

       'INSERT record
       Connect()

       sql = "SELECT (sname) FROM tblsample WHERE sname = @sname"
       cmd = New OleDbCommand(sql, conn)

       cmd.Parameters.Add(New OleDbParameter("@sname", OleDbType.VarChar, 255)).Value = TextBox1.Text

       Dim rec = cmd.ExecuteScalar

       If rec = TextBox1.Text Then
           MessageBox.Show("Name already exist.", "", MessageBoxButtons.OK, MessageBoxIcon.Exclamation)
           Exit Sub
       End If

       conn.Close()
       conn.Dispose()
       cmd.Dispose()

       Try

           Connect()

           Trans = conn.BeginTransaction

           sql = "INSERT INTO tblsample(sname,contact) VALUES(@sname,@contact)"

           cmd = New OleDbCommand(sql, conn, Trans)

           cmd.Parameters.Add(New OleDbParameter("@sname", OleDbType.VarChar, 255)).Value = TextBox1.Text

           cmd.Parameters.Add(New OleDbParameter("@contact", OleDbType.VarChar, 255)).Value = TextBox2.Text

           cmd.ExecuteNonQuery()

           Trans.Commit()

           conn.Close()
           conn.Dispose()
           cmd.Dispose()

           MessageBox.Show("Saved.", "", MessageBoxButtons.OK, MessageBoxIcon.Information)
           Call loadrec()
       Catch ex As Exception
           Trans.Rollback()
           MessageBox.Show(ex.Message, "", MessageBoxButtons.OK, MessageBoxIcon.Error)
       End Try

   End Sub

Private Sub Button3_Click(sender As System.Object, e As System.EventArgs) Handles Button3.Click

       'DELETE record
       Try
           Connect()

           Trans = conn.BeginTransaction

           sql = "DELETE FROM tblsample WHERE ID = @ID"

           cmd = New OleDbCommand(sql, conn, Trans)

           cmd.Parameters.Add(New OleDbParameter("@ID", OleDbType.Integer)).Value = DataGridView1.SelectedCells(0).Value

           cmd.ExecuteNonQuery()

           Trans.Commit()

           conn.Close()
           conn.Dispose()
           cmd.Dispose()

           Call loadrec()

           MessageBox.Show("DELETED!", "", MessageBoxButtons.OK, MessageBoxIcon.Information)

       Catch ex As OleDb.OleDbException
           Trans.Rollback()
           MessageBox.Show(ex.Message, "DATABASE ERROR", MessageBoxButtons.OK, MessageBoxIcon.Error)
       Catch ex As Exception
           Trans.Rollback()
           MessageBox.Show(ex.Message)
       End Try

   End Sub

Private Sub Button2_Click(sender As System.Object, e As System.EventArgs) Handles Button2.Click

       'UPDATE record
       Try
           Connect()

           Trans = conn.BeginTransaction

           sql = "UPDATE tblsample SET sname = @sname,contact = @contact WHERE contact = @ID"

           cmd = New OleDbCommand(sql, conn, Trans)

           cmd.Parameters.Add(New OleDbParameter("@sname", OleDbType.VarChar, 255)).Value = TextBox1.Text
           cmd.Parameters.Add(New OleDbParameter("@contact", OleDbType.VarChar, 255)).Value = TextBox2.Text
           cmd.Parameters.Add(New OleDbParameter("@ID", OleDbType.Integer)).Value = DataGridView1.SelectedCells(0).Value

           cmd.ExecuteNonQuery()

           Trans.Commit()

           conn.Close()
           conn.Dispose()
           cmd.Dispose()
           Call loadrec()
           MessageBox.Show("UPDATED!", "", MessageBoxButtons.OK, MessageBoxIcon.Information)

       Catch ex As Exception
           Trans.Rollback()
           MessageBox.Show(ex.Message)
       End Try

   End Sub
Tags: Visual Basic, Microsoft Access

Plain Text
ASM
ASP
ASP.NET
BASIC
BAT
C#
C++
COBOL
CoffeeScript
CSS
Dart
dbase
F#
FORTRAN
HTML
Java
Javascript
Kotlin
Lua
MIDL
MSIL
ObjectiveC
Pascal
PERL
PHP
PowerShell
Python
Razor
Ruby
Scala
Shell
SLN
SQL
Swift
T4
Terminal
TypeScript
VB
VBScript
XML
YAML

Preview



When answering a question please:
  1. Read the question carefully.
  2. Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
  3. If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
  4. Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.
Let's work to help developers, not make them feel stupid.
Please note that all posts will be submitted under the http://www.codeproject.com/info/cpol10.aspx.



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900