String permutation recursion, segmentation fault

Quote:

im learning string permutation, what is wrong with my code?

First, you code is playing with integers, not strings.

Quote:

it produce segmentation fault?

No matter what you did exactly, your code is trying to read/write a memory place it don't own, this means that it try to read/write after the end of an array/vector.

Quote:

i tried to debug it but produce segmentation fault error.

Debugger does not correct anything, it only show you what is doing your code, The debugger shows you the position of error and values of variables.
If you look carefully, you will see what operation is wrong.

By the way, telling us the position or error would help us to spot what is the problem, because the array in this line of code is the guilty one.
-----
Advice: Learn to indent properly your code, it show its structure and it helps reading and understanding. It also helps spotting structures mistakes.

#include <bits/stdc++.h>
using namespace std;


// Function to print permutations of string
// This function takes three parameters:
// 1. String
// 2. Starting index of the string
// 3. Ending index of the string.
vector<vector<int>> permute(vector<int>nums,vector<vector<int>>k,vector<int>li)
{
    if(nums.empty()){
        k.push_back(li);
    }else{
        for(int i=0;i<nums.size();i++){
            int chos=nums[i];
            li.push_back(chos);
            nums.erase(nums.begin()+i);
            permute(nums,k,li);
            nums.insert(nums.begin()+i,chos);
            li.erase(li.end());
        }
    }
}

// Driver Code
int main()
{
    vector<int>permut={1,2,3};
    vector<vector<int>>k;
    vector<int>li;

    permute(permut,k,li);
    return 0;
}

Indentation style - Wikipedia[^]

Professional programmer's editors have this feature and others ones such as parenthesis matching and syntax highlighting.
Notepad++ Home[^]
ultraedit[^]

li.erase(li.end());

will always crash! Reason: std::vector<int>::erase() with one argument takes an iterator and tries to eliminate an element at the position referenced by this iterator. Since end() by definition is the iterator that points nowhere, you're accessing 'nowhere' --> seg fault!

Maybe you intended to clear the list? This could be achieved using the two argument variant of erase:

li.erase(li.begin(); li.end());

But, much simpler, you could just use clear():

li.clear();

P.S.: just noticed there already is a solution pointing out this error. I'll leave mine up here anyway, because of the suggestions how to fix it.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:

Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16

Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:

int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!