Vb.net: there is an error with this code.please help. Im a newbie and was given this snippet of code to fix

Question

1.00/5 (1 vote)

See more:

VB

SQLCmd.CommandText = "INSERT INTO PriceBook_Cost (EntryDate, Country, PoP, City, Medium, Capacity, Currency, " &
"NRC, MRC) VALUES ('" &
DateTime.Now & "','" &
country.Replace("'", "''") & "','" &
PBPoPtoUse.Replace("'", "''") & "','" &
city.Replace("'", "''") & "','" &
theMedium & "','" &
MB & "','" &
"USD',’" &
If(MaxNRC > 0, "'" & Convert.ToInt64(MaxNRC) & "'", "NULL") & "," &
If(MinMRC > 0, "'" & Convert.ToInt64(MinMRC) & "'", "NULL") & ")"

What I have tried:

Hi. Im a newbie at VB.net please help to figure out the problem to fix this snippet of code

Posted 20-Nov-19 9:27am

Nigelg11

Updated 18-Aug-20 10:54am

Richard MacCutchan

v2

Add a Solution

Comments

Richard MacCutchan 20-Nov-19 15:41pm

Yes, it is unreadable.

Patrice T 20-Nov-19 16:14pm

and the error message is ?

Dave Kreskowiak 20-Nov-19 19:23pm

And you never mentioned what you meany by "fix". What about this code, specifically, is broken, other than the obvious string concatenation to build the SQL query.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2019-11-20T10:04:00

Don't do it like that. OK, you are replacing quote with a pair of quotes, but that doesn't really protect you well - and makes your code very difficult to read.

Instead, use parameterised queries:

VB

Using con As New MySqlConnection(strConnect)
	con.Open()
	Using com As New MySqlCommand("INSERT INTO myTable (myColumn1, myColumn2) VALUES (@C1, @C2)", con)
		com.Parameters.AddWithValue("@C1", myValueForColumn1)
		com.Parameters.AddWithValue("@C2", myValueForColumn2)
		com.ExecuteNonQuery()
	End Using
End Using

It's safer, you don't need to faff with Replace, and it's a whole load more readable. You'll probably find that it fixes your problem at the same time.