When I enterd password and user name its not work only page refresh why is that?

Question

0.00/5 (No votes)

See more:

(database= newweb
table= loginform
user01 = janaka
pass01= janaka)

What I have tried:

<pre><?php

$host = "localhost";
$user = "root";
$Password = "";
$db = "newweb";

mysql_connect($host, $user, $Password);
mysql_select_db($db);

if (isset($_post['UserName'])) 
{
	$Uname = $_post['UserName'];
	$Password = $_post['Password'];

	$sql = "select * from loginform where User01='".$Uname."' AND Pass01='".$Password."' limit 1";

	$result=mysql_query($sql);

	if(mysql_num_rows($result)==1)
	{
		echo "You have sucessfully logged in";
		exit();
		}
			else
			{
				echo "You have entered incorrect Password";
				exit();
}
}
?>
<!DOCTYPE html>
<html>
<head>
	<title></title>
	<link rel="stylesheet" type="text/css" href="logingform.css">
	<link rel="stylesheet" type="text/css" href="l.css">
</head>
<body>
	<div class="logingbox">
		<img src="user.png" class="avatar">
		<h1>Loging Here</h1>
			<form method="post" action="#">
				<p>User name</p>
				<input type="text" name="User Name" placeholder="Enter UserName">
				<p>Password</p>
				<input type="Password" name="Password" placeholder="Enter Password"><br>
				<input type="submit" name="submit" value="Login"><br>
				<a href="a">Forget Password</a><br><br>
				<p class="not-an-account">If you don't have a account</p>
				                      <a href="b">Sign Up</a>
			</form>
	</div>
</body>
</html>

Posted 13-Dec-19 16:16pm

Janaka Ravindra

Updated 13-Dec-19 20:47pm

Add a Solution

Comments

Richard MacCutchan 14-Dec-19 5:50am

Please, please, do NOT store your passwords in clear text.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2019-12-13T16:31:00

PHP

$sql = "select * from loginform where User01='".$Uname."' AND Pass01='".$Password."' limit 1";

Not necessary a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]

OriginalGriff · Answer 2 · 2019-12-13T20:48:00

To add to what PatriceT says:
1) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

2) Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^] - the code is in C#, but PHP has methods to do it for you: password_hash() – used to hash the password, and password_verify() – used to verify a password against its hash.
And remember: if this is web based and you have any European Union users then GDPR applies and that means you need to handle passwords as sensitive data and store them in a safe and secure manner. Text is neither of those and the fines can be .... um ... outstanding. In December 2018 a German company received a relatively low fine of €20,000 for just that.

When I enterd password and user name its not work only page refresh why is that?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0