Getting error "incorrect function" in a function on specific computers

Question

0.00/5 (No votes)

See more:

Using vb.NET I using XmlDocument to load, modify then save an existing XML file. The loading and modifying work, but I am getting an error "Incorrect function" when trying to save the XML. I am getting this error as the message from a try catch. Even when I comment out my code in the middle of the load and save, I still get this error...

Target framework: .NET Framework 4.5.
Application type: Windows Forms Application

This is a PC issue, as it does work on some Windows PCs but not others. I tried comparing a few things but I am not sure what to look for to compare.

I am new at coding and not sure what to do. Everything that I am Googling is above my head. Can you please help, like you were trying to help a 7 year old.

Thank you in advance!

Code:

VB.NET

Imports System.Xml
Dim ShipXMLDocument As XmlDocument = New XmlDocument()
ShipXMLDocument.Load(FilePath)
Dim objNodeList = Nothing

objNodeList = ShipXMLDocument.DocumentElement.SelectNodes("//ShipShipment/DataArea/Shipment/Header/Parties/Party")

If objNodeList.Count > 0 Then
	For i = 0 To objNodeList.Count - 1
		If objNodeList.Item(i).FirstChild.InnerText <> "SHIPPER" Then
			For ChildNode = 0 To objNodeList.Item(i).ChildNodes.Count - 1
				If objNodeList.Item(i).ChildNodes.Item(ChildNode).Name = "Name" Then
					objNodeList.Item(i).ChildNodes.Item(ChildNode).InnerText = "Tester McTestingstein"
				ElseIf objNodeList.Item(i).ChildNodes.Item(ChildNode).Name = "EmailAddress" Then
					objNodeList.Item(i).ChildNodes.Item(ChildNode).InnerText = "Testing@Testing.com"
				End If
			Next
		End If
	Next
End If

ShipXMLDocument.Save(FilePath)

I am getting this as the stack trace:

Quote:
at Microsoft.VisualBasic.CompilerServices.Symbols.Container.InvokeMethod(Method TargetProcedure, Object[] Arguments, Boolean[] CopyBack, BindingFlags Flags)
at Microsoft.VisualBasic.CompilerServices.NewLateBinding.CallMethod(Container BaseReference, String MethodName, Object[] Arguments, String[] ArgumentNames, Type[] TypeArguments, Boolean[] CopyBack, BindingFlags InvocationFlags, Boolean ReportErrors, ResolutionFailure& Failure)
at Microsoft.VisualBasic.CompilerServices.NewLateBinding.ObjectLateCall(Object Instance, Type Type, String MemberName, Object[] Arguments, String[] ArgumentNames, Type[] TypeArguments, Boolean[] CopyBack, Boolean IgnoreReturn)
at Microsoft.VisualBasic.CompilerServices.NewLateBinding.LateCall(Object Instance, Type Type, String MemberName, Object[] Arguments, String[] ArgumentNames, Type[] TypeArguments, Boolean[] CopyBack, Boolean IgnoreReturn)
at Apollo_Shipping.Functions.XML_ScrubContactInformation(Object FilePath) in C:\Temp\Send Test Shipment\Send Test Shipment\Functions.vb:line 584

What I have tried:

- Running this code on another Windows PC.
- Commenting out my code in the middle of loading the XML and saving the XML.

Posted 3-Jan-20 7:15am

JoshuaKo

Updated 27-Jan-20 16:39pm

v2

Add a Solution

Comments

Christian Graus 3-Jan-20 22:02pm

If it works on some computers and not others, it means that some library this code uses is not present. Can you check what versions of .NET those computers have installed (although XmlDocument was there from the start I thought)

For i = 0 To objNodeList.Count - 1

VB is pretty crap, but if you need the -1, it's very crap indeed. Are you sure?

JoshuaKo 4-Jan-20 20:51pm

Christian,

Thank you for your comment. Please note that even when I comment out my code in the middle of loading the XML and saving the XML I still get the same error.

When using (Get-ItemProperty "HKLM:SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full").Release in PowerShell I get the same answer, "528040". I got this query from https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed#ps_a

Christian Graus 4-Jan-20 21:56pm

I posted a fuller reply as an answer.

Clearly if your saving code blows up, the editing code is irrelevant. Why not try what I suggested instead?

JoshuaKo 4-Jan-20 23:31pm

I will try to use File.SaveAllText but I wanted try to figure out what the root cause is and not just apply a workaround.

Is there a way to determine which library is being used to confirm if that library is there or corrupted?

Christian Graus 5-Jan-20 0:06am

According to docs, there's no external library involved, so it all seems odd. TBH I am expecting you to say it also doesn't work and the issue is something else, like you trying to write a protected file.

JoshuaKo 5-Jan-20 0:34am

You are correct. I tried using File.WriteAllText(FilePath, ShipXMLDocument.InnerXml) and I am getting the below Stack Trace:
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
at System.IO.File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)
at System.IO.File.WriteAllText(String path, String contents)
at Apollo_Shipping.Functions.XML_ScrubContactInformation(Object FilePath) in \\xxxx\Functions.vb:line 604

Does that Stack Trace give you better insight?

Regarding, "you trying to write a protected file", I am able to modify that XML in notepad successfully on the computer that is having this issue. Also, note that under my login on another computer, this function works perfectly.

JoshuaKo 5-Jan-20 0:40am

To be clear, I replaced "ShipXMLDocument.Save(FilePath)" with "File.WriteAllText(FilePath, ShipXMLDocument.InnerXml)".

Christian Graus 5-Jan-20 0:36am

For example. if you had the XML open in another program, it would be locked. The error, not the stack trace, would help. Try writing to a file you KNOW does not exist.

JoshuaKo 5-Jan-20 0:44am

I was able to create a new file with my modifications. So what does that mean? How can I write to the same file?

Christian Graus 5-Jan-20 0:47am

Your issue is that the file is locked. I suspect the XMlDocument class actually has it locked. IF it has a Dispose method, put it in a using block. Store the XML in a variable, close the document, then save it using the code you've just written

JoshuaKo 5-Jan-20 0:52am

There is no dispose/close method. Also, GC.Collect() doesn't work either, before the save.

Christian Graus 5-Jan-20 0:53am

OK, then just close the file. GC.Collect is almost always a bad idea. IF there's no dispose, there's no issue. The only other thing is if you have the file open in Word for example while you work on the code

JoshuaKo 5-Jan-20 1:00am

"IF there's no dispose, there's no issue.", but this is my issue. I need to modify and save the same file and I don't know how to let the lock go. I tried:

Dim tempXMLText As String = ShipXMLDocument.InnerXml
ShipXMLDocument = Nothing
File.WriteAllText(FilePath, tempXMLText)

But that didn't work either.

The weird thing about all of this is that is works fine on my computer but not the users.

Christian Graus 5-Jan-20 1:07am

Did you do ShipXmlDocument.Close like I said?

It can't work on any computer if you have the file locked. If it works on some, it's another program keeping the file open.

https://alternativeto.net/software/wholockme/

These programs will help you work out what is locking a file

JoshuaKo 5-Jan-20 1:15am

There is no ShipXmlDocument.Close method... :(

I will look at this url but, wouldn't it just tell me that I am locking it with my program?

Christian Graus 5-Jan-20 1:47am

I don't think so. Your code is the same everywhere. So I think you have a program locking it on some machines

JoshuaKo 5-Jan-20 2:04am

OK, thank you this is going to take time then. Thank you for all your help so far.

Christian Graus 5-Jan-20 2:08am

No worries :)

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Christian Graus · Answer 1 · 2020-01-03T17:03:00

mports System.Xml
Dim ShipXMLDocument As XmlDocument = New XmlDocument()
ShipXMLDocument.Load(FilePath)
Dim objNodeList = Nothing

objNodeList = ShipXMLDocument.DocumentElement.SelectNodes("//ShipShipment/DataArea/Shipment/Header/Parties/Party")

This makes no sense. Why not just set it's value in the first line?

If objNodeList.Count > 0 Then
	For i = 0 To objNodeList.Count - 1

I doubt that count - 1 is correct. Also, you can do a foreach on the node list instead of having to look them up by index

If objNodeList.Item(i).FirstChild.InnerText <> "SHIPPER" Then
    For ChildNode = 0 To objNodeList.Item(i).ChildNodes.Count - 1
        If objNodeList.Item(i).ChildNodes.Item(ChildNode).Name = "Name" Then

I am fairly certain you could use an xpath to exclude 'SHIPPER' as a value.

objNodeList.Item(i).ChildNodes.Item(ChildNode).InnerText = "Tester McTestingstein"
            ElseIf objNodeList.Item(i).ChildNodes.Item(ChildNode).Name = "EmailAddress" Then

This sort of code turns into spaghetti fast. Use a switch statement to operate no different nodes. Also, if you're looking at node names, not values, you would do better having two node collections at this level, one for each node you want to work with

					objNodeList.Item(i).ChildNodes.Item(ChildNode).InnerText = "Testing@Testing.com"
				End If
			Next
		End If
	Next
End If

ShipXMLDocument.Save(FilePath)

If this is blowing up, I would try storing the XML in a string and using File.SaveAllText to save it and see if that works

JoshuaKo · Answer 2 · 2020-01-27T16:41:00

Solution 2

Update: The issue was the anti Virus.

Posted 27-Jan-20 16:41pm