How do I stop the loop from being a continuous loop?

Question

0.00/5 (No votes)

See more:

Python

userChoice2 = input("What is the coin type you want to count?: ")
while userChoice2 not in ["1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2"]:
       print("Wrong input")
       print("You have to pick one from" "1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2")



If an invalid response is entered the program continuously prints the final two print commands.

What I have tried:

I have tried using a function and making the while loop true and false.

Posted 10-Jan-20 23:40pm

Coding1014

Updated 11-Jan-20 4:23am

Add a Solution

Comments

[no name] 11-Jan-20 5:47am

input needs to be inside the while loop

Coding1014 11-Jan-20 5:50am

Where in the while loop?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-01-10T23:52:00

Look at your code: the loop consists of three lines:

while userChoice2 not in ["1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2"]:
       print("Wrong input")
       print("You have to pick one from" "1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2")

But none of them change the value in userchoice2 so once you enter the loop with a bad input, you will continually check the same bad value and print the same messages.
What you need to do is copy the input line so that after you print the error messages, you can get a new value:

userChoice2 = input("What is the coin type you want to count?: ")
while userChoice2 not in ["1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2"]:
       print("Wrong input")
       print("You have to pick one from" "1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2")
       userChoice2 = input("What is the coin type you want to count?: ")

CPallini · Accepted Answer · 2020-01-11T04:24:00

Solution 2

Try also

Python

allowed =  ["1p", "2p", "5p", "10p", "20p", "50p", "£1", "£2"]
while True:
  userChoice2 = input("What is the coin type you want to count?: ")
  if userChoice2 in allowed:
    break
  print("you have to pick one from ", allowed)

Posted 11-Jan-20 4:24am

CPallini