Click here to Skip to main content
15,895,709 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
C++
#include<stdlib.h>
#include<stdio.h>
#include<iostream>
#include<math.h>
using namespace std;
void InsertSort(int *A,int n){
    for(int p=1;p-1<n;p++)
    {
        int key=A[p-1];//It used to compare
        while(key>A[p]){
            int temp=A[p];
            A[p]=A[p-1];
            A[p-1]=temp;
            for(int i=p-1;A[i]<A[i-1];i--){
                int temp=A[i];
                A[i]=A[i-1];
                A[i-1]=temp;
            }
        }
    }
}
void Merge(int* A,int left,int mid,int right){
    int i,j,k;
    int n1=mid-left+1;
    int n2=right-mid;
    //create the temprorte array
    int* L=(int*)malloc(n1*sizeof(int));
    int* R=(int*)malloc(n2*sizeof(int));
    //use a loop to merge
    for(i=0;i<n1;i++){
        L[i]=A[left+i];
    }
    for(j=0;j<n2;j++){
        R[j]=A[mid+1+j];
    }
    /* Merge the temp arrays back into arr[l..r] */
    i = 0; // Initial index of first subarray
    j = 0; // Initial index of second subarray
    k = left; // Initial index of merged subarray
    for (; i < n1 && j < n2; k++) {
        if (L[i] <= R[j]) {
            A[k] = L[i];
            i++;
        } else {
            A[k] = R[j];
            j++;
        }
    }
    /* Copy the remaining elements of L[], if there
    are any */
    for(; i < n1; i++, k++){
        A[k] = L[i];
    }
    /* Copy the remaining elements of R[], if there
    are any */
    for(; j < n2; j++, k++){
        A[k] = R[j];
    }

    free(L);
    free(R);
} 
void MergeSort(int* A,int left,int right){
    if(right<left){
    // when the size of the subarray is two, stop dividing
        int mid=left+(right-left)/2;
        MergeSort(A,left,mid);
        MergeSort(A,mid+1,right);
        Merge(A, left, mid, right);
    }
}
int main(){
    int* arrIS;//array for insertion sort
    int* arrME;//array for merge sort;
    int n1=10,n2=pow(10,5);
    //n1=10 TEST
    arrIS=(int*)malloc(n1*sizeof(int));
    arrME=(int*)malloc(n1*sizeof(int));

    //assign values to both arrays
    srand(time(NULL));//Should only be called once
    for(int i=0;i<n1;i++){
        int r=rand()%10;
        arrIS[i]=r;
        arrME[i]=r;
    }
    //print out the result
    //This is for the insertsort method
    for(int i=0;i<n1;i++){
        cout<<arrIS[i]<<" ";
    }cout<<endl;
    InsertSort(arrIS,n1);
    for(int i=0;i<n1;i++){
        cout<<arrIS[i]<<" ";
    }cout<<endl;
    //This is for the mergesort method
    for(int i=0;i<n1;i++){
        cout<<arrME[i]<<" ";
    }cout<<endl;
    MergeSort(arrME,0,n1-1);
    for(int i=0;i<n1;i++){
        cout<<arrME[i]<<" ";
    }cout<<endl;
}


What I have tried:

I got this:
7 1 0 9 1 5 9 4 7 3
0 1 1 3 4 5 7 7 9 9
7 1 0 9 1 5 9 4 7 3
7 1 0 9 1 5 9 4 7 3


The result of MergeSort method should be the same as the InsertSort method.I don't understand why it doesn't work.
Posted
Updated 27-Apr-20 3:47am
v3
Comments
Patrice T 27-Apr-20 9:22am    
What is input, what is output ?

This is a complicated way to calculate a mean:
C++
int mid=left+(right-left)/2;
// it can be rewritten to
int mid=(left*2+right-left)/2;
// then simplified to
int mid=(right+left)/2;

C++
void MergeSort(int* A,int left,int right){
    if(right<left){ // pay attention to this test 
    // when the size of the subarray is two, stop dividing
        int mid=left+(right-left)/2;
        MergeSort(A,left,mid);
        MergeSort(A,mid+1,right);
        Merge(A, left, mid, right);
    }
}

This is not a direct solution to your problem, but a tool that will allow you to see and understand what is going on in your code. Once you understand what is going wrong, the correction is not far away.
Quote:
The result of MergeSort method should be the same as the InsertSort method.I don't understand why it doesn't work.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.
 
Share this answer
 
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900