Describe class economic binary counter

Question

0.00/5 (No votes)

See more:

It may sound like a task itself: it can increase or decrease its value by one in a given range. An initialization value is provided. In the absence abroad, exceptions are thrown.
And now I wanted to ask you if everything meets the condition or am I missing something?

What I have tried:

C#

using System;
namespace laba7
{
    public class Program
    {
        public static void Main()
        {
            int x, y, z;
            Console.WriteLine("Начало решения");
            Console.WriteLine("Введите значение");
            x = int.Parse(Console.ReadLine());
            Console.WriteLine("Введите минимум");
            y = int.Parse(Console.ReadLine());
            Console.WriteLine("Введите максимум");
            z = int.Parse(Console.ReadLine());
            Counter counter = new Counter(x, y, z);
            counter--;
            Console.WriteLine("Ответ: {0}", counter.Value);
            
            Console.WriteLine("Конец решения");
            Console.ReadLine();

        }

        class Counter
        {
            int val;

            public int Value
            {
                get { return val; }
                set { val = value; InRange(); }
            }

            private int min { get; set; }

            private int max { get; set; }

            public Counter(int _val, int _min, int _max)
            {
                min = _min;
                max = _max;
                Value = _val;
            }

            public Counter(int _min, int _max)
            {
                min = _min;
                max = _max;
                Value = new Random().Next(min, max + 1);
            }

            public static Counter operator ++(Counter c)
            {
                c.Value++;
                return c;
            }

            public static Counter operator --(Counter c)
            {
                c.Value--;
                return c;
            }

            void InRange()
            {
                try
                {
                    if (val > max || val < min)
                        throw new ArgumentOutOfRangeException("Значение не в заявленном диапазоне.");
                }
                catch (ArgumentOutOfRangeException e)
                {
                    Console.WriteLine($"Ошибка: {e}");
                }
            }

        }

    }
}

Posted 1-Jun-20 3:33am

Grampy Cat

Updated 2-Jun-20 0:32am

Add a Solution

Comments

Richard MacCutchan 1-Jun-20 11:32am

Does it work according to the requirements?

Grampy Cat 2-Jun-20 2:10am

Well, it seems like yes, but for example it adds or subtracts a unit only depending on this line at the beginning, but should it be so?

Counter counter = new Counter(x, y, z);
counter--;

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2020-06-02T00:33:00

Quote:

C#

try
{
    if (val > max || val < min)
        throw new ArgumentOutOfRangeException("Значение не в заявленном диапазоне.");
}
catch (ArgumentOutOfRangeException e)
{
    Console.WriteLine($"Ошибка: {e}");
}

That bit makes no sense. Throwing an exception just so you can catch it on the next line and write a message to the console wastes a lot of resources. Just use:

C#

if (val > max || val < min)
    Console.WriteLine("Ошибка: Значение не в заявленном диапазоне.");

But you'll still have the issue that your object is in an invalid state, and the caller has no way of knowing that. It would be better to validate the value before changing the state of your object:

C#

public int Value
{
    get { return val; }
    set 
    { 
        if (value > max || value < min)
            throw new ArgumentOutOfRangeException("Значение не в заявленном диапазоне.");
        
        val = value;
    }
}