How do I solve this "parse error: syntax error, unexpected 'else' (T_ELSE) in C:\xampp\htdocs\admin\code.php on line 23"

Question

0.00/5 (No votes)

See more:

The error is located here:

PHP

else {
            $_SESSION['status'] = "New Admin entry NOT successful or cancelled";
            header ('Location: register.php');
        }

This is the full code I have.

PHP

<?php
session_start();

$connection=mysqli_connect("locahost","root","","adminpanel");
if(isset($_POST['registerbtn']))
{
    $fullname=$_POST['fullname'];
    $office=$_POST['office'];
    $school=$_POST['school'];
    $email=$_POST['email'];
    $username=$_POST['username'];
    $password=$_POST['password'];
    $cpassword=$_POST['confirmpassword'];

    if($password === $cpassword) {
        $query = "INSERT INTO register (fullname,office,school,email,username,password) VALUES ('$fullname','$office','$school','$email','$username,'$password')";
        $query_run = mysqli_query($connection, $query);
    
        if($query_run); {
            $_SESSION['success'] = "New Site Admin added";
            header ('Location: register.php');
        }
        else {
            $_SESSION['status'] = "New Admin entry NOT successful or cancelled";
            header ('Location: register.php');
        }
    }
    else {
        $_SESSION['status'] = "Password and Confirm Password Do Not Match";
        header ('Location: register.php');
        }
}

?>

What I have tried:

I have tried to figure out the correct pairing of the opening and closing of every code but I guess everything is okay.

Posted 8-Aug-20 20:26pm

JeffLiteral

Updated 8-Aug-20 20:48pm

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-08-08T20:41:00

The problem you have noticed is because of this:

PHP

if($query_run); {

Remove the semicolon, and it should go away.

BUT ... that is a trivial problem compared the one tones you haven't noticed yet.

1) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

2) Never store passwords in clear text - it is a major security risk. You need to hash the salted password and store the hash value instead of storing the password itself. When you come to check the password next time, you salt the user input, then hash that and compare the two hashes. If they differ, it's the wrong password.

And remember: if this is web based and you have any European Union users then GDPR applies and that means you need to handle passwords as sensitive data and store them in a safe and secure manner. Text is neither of those and the fines can be .... um ... outstanding. In December 2018 a German company received a relatively low fine of €20,000 for just that.

Fix both of those through your whole app as a serious priority!

Patrice T · Accepted Answer · 2020-08-08T20:48:00

May be because of the semicolon there:

PHP

if($query_run); {

PHP

$query = "INSERT INTO register (fullname,office,school,email,username,password) VALUES ('$fullname','$office','$school','$email','$username,'$password')";

Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]

How do I solve this "parse error: syntax error, unexpected 'else' (T_ELSE) in C:\xampp\htdocs\admin\code.php on line 23"

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0