Getting Error in Inserting Record

Question

0.00/5 (No votes)

See more:

I am trying to insert Record into a Database, but i am getting following error.

Incorrect Syntax error near ')'

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Data.SqlClient;


namespace Thursday
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        private void Form1_Load(object sender, EventArgs e)
        {

        }

        private void button1_Click(object sender, EventArgs e)
        {
            try
            {

                SqlConnection sqlconn = new SqlConnection("Data Source=AAN-PC;Initial Catalog=Thusdata;Integrated Security=True");
                SqlDataAdapter sa = new SqlDataAdapter();
                sa.InsertCommand = new SqlCommand("insert into Table_1(SensorValue)",sqlconn);
                sa.InsertCommand.Parameters.Add("@SensorValue", SqlDbType.Int).Value = SensorValue.Text;
                sqlconn.Open();
                try
                {
                    sa.InsertCommand.ExecuteNonQuery();
                }
                catch (FormatException ex) { MessageBox.Show(ex.Message); }
                MessageBox.Show("Record Inserted");
                sqlconn.Close();
            }
            catch (SqlException ea) { MessageBox.Show(ea.Message); }
        }

        private void textBox1_TextChanged(object sender, EventArgs e)
        {

        }
    }
}

Posted 16-Jan-13 18:44pm

ontheline89

Updated 16-Jan-13 18:55pm

sisir patro

v2

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Shambhoo kumar · Accepted Answer · 2013-01-16T19:22:00

Solution 4

replace two line of your code for this

C#

sa.InsertCommand = new SqlCommand("insert into Table_1(SensorValue)values(@SensorValue)",sqlconn);
sa.InsertCommand.Parameters.AddWithValue("@SensorValue", SensorValue.Text);

Posted 16-Jan-13 19:22pm

Shambhoo kumar

Comments

fjdiewornncalwe 17-Jan-13 9:55am

My 5. This is the way to do this.

Shambhoo kumar 18-Jan-13 12:20pm

Thanks.. :)

AdityaPratapSingh · Accepted Answer · 2013-01-16T18:50:00

Solution 1

change ur code as given below

C#

sa.InsertCommand = new SqlCommand("insert into Table_1(SensorValue) values (@SensorValue)",sqlconn);

Posted 16-Jan-13 18:50pm

AdityaPratapSingh

Comments

ontheline89 17-Jan-13 0:54am

Thank you for your reply but i am still getting error.

Must Declare the Scalar Variable "@SensorValue"

sisir patro · Accepted Answer · 2013-01-16T19:03:00

Solution 2

HI,

Insetead of using the code like:

SQL

SqlDataAdapter sa = new SqlDataAdapter();
                sa.InsertCommand = new SqlCommand("insert into Table_1(SensorValue)",sqlconn);
                sa.InsertCommand.Parameters.Add("@SensorValue", SqlDbType.Int).Value = SensorValue.Text;

Use like:

SQL

SqlDataAdapter sa = new SqlDataAdapter();
string query = "insert into Table_1(SensorValue) values(" + SensorValue.Text + ")";
                sa.InsertCommand = new SqlCommand(query ,sqlconn);

Thanks

Posted 16-Jan-13 19:03pm

sisir patro

Comments

ontheline89 17-Jan-13 1:08am

Thank you so much Sisri Patro.
It worked.

[no name] 17-Jan-13 1:16am

Yours welcome dear...

fjdiewornncalwe 17-Jan-13 9:54am

This answer is nothing more than an sql injection invasion request. SQL queries should ALWAYS use paramatarized arguments, not inline ones as you suggest here.

[no name] 17-Jan-13 10:07am

I would rather suggest for the stored procedure not inline query.

AdityaPratapSingh · Accepted Answer · 2013-01-16T19:11:00

use this

C#

SqlConnection sqlconn = new SqlConnection("Data Source=AAN-PC;Initial Catalog=Thusdata;Integrated Security=True");
                SqlDataAdapter sa = new SqlDataAdapter();	
				sa.InsertCommand = new SqlCommand("insert into Table_1(SensorValue) values ("+SensorValue.Text+")",sqlconn);
                
                sqlconn.Open();
try
{
 sa.InsertCommand.ExecuteNonQuery();
}				
catch (FormatException ex) { MessageBox.Show(ex.Message); }
                MessageBox.Show("Record Inserted");
                sqlconn.Close();

Getting Error in Inserting Record

4 solutions

Solution 4

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us