String was not recognized as a valid datetime format

Question

0.00/5 (No votes)

See more:

Hii ,

i am getting this error please help me to resolve

What I have tried:

C#

private void dtTmPckrEndDt_CloseUp_1(object sender, EventArgs e)
        {
            if (!string.IsNullOrEmpty(dtTmPckrStartDt.Text) && !string.IsNullOrEmpty(dtTmPckrEndDt.Text))
            {
                DateTime StartDate = DateTime.ParseExact(dtTmPckrStartDt.Text, "dd/MMM/yyyy", CultureInfo.InvariantCulture);
                DateTime EndDate = DateTime.ParseExact(dtTmPckrEndDt.Text, "dd/MMM/yyyy", CultureInfo.InvariantCulture);
                if (StartDate > EndDate)
                {
                    MessageBox.Show("Start Date Must be Less than End Date ");
                    dtTmPckrEndDt.CustomFormat = " ";
                }
            }
        }

Posted 8-Mar-21 0:39am

Member 15088142

Updated 8-Mar-21 5:04am

PIEBALDconsult

v2

Add a Solution

3 solutions

Solution 3

private void dtTmPckrEndDt_CloseUp_1(object sender, EventArgs e)
{
if (!string.IsNullOrEmpty(dtTmPckrStartDt.Text) && !string.IsNullOrEmpty(dtTmPckrEndDt.Text))
{
DateTime StartDate = DateTime.Now;
DateTime EndDate = DateTime.Now;

if (DateTime.TryParseExact(dtTmPckrStartDt.Text, "dd/MMM/yyyy", null, System.Globalization.DateTimeStyles.None, out StartDate) && DateTime.TryParseExact(dtTmPckrEndDt.Text, "dd/MMM/yyyy", null, System.Globalization.DateTimeStyles.None, out EndDate)
{
if (StartDate > EndDate)
{
MessageBox.Show("Start Date Must be Less than End Date ");
dtTmPckrEndDt.CustomFormat = " ";
}
else
{
MessageBox.Show("Invalid Start Or End Date");

}
}
}
}

Posted 8-Mar-21 5:04am

Sonu uniyal

Updated 8-Mar-21 5:05am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2021-03-08T00:50:00

Solution 1

You should use: DateTimePicker.Value Property (System.Windows.Forms) | Microsoft Docs[^]

C#

DateTime StartDate = dtTmPckrStartDt.Value;
DateTime EndDate = dtTmPckrEndDt.Value;

Posted 8-Mar-21 0:50am

Maciej Los

OriginalGriff · Accepted Answer · 2021-03-08T01:00:00

To add to what Maciej says, don't use DateTime.ParseExact on user provided date strings anyway - you are assuming a format that the user may not be using on his computer, and that can cause your app to crash.
Instead, use DateTime.TryParse which assumes the current user language settings and returns a "success / fail" signal instead of crashing your app with an exception.

But in this case, as Maciej says, use the Value property and you get a guaranteed valid DateTime value directly without any need for conversions at all.